Uh oh!
There was an error while loading. Please reload this page.
fs::copy() unix: set file mode early - #58909
Closed
haraldh wants to merge 1 commit into
Closed
Conversation
same fix as commit fb98ca7 PR: rust-lang#58803 A convenience method like fs::copy() should try to prevent pitfalls a normal user doesn't think about. In case of an empty umask, setting the file mode early prevents temporarily world readable or even writeable files, because the default mode is 0o666. In case the target is a named pipe or special device node, setting the file mode can lead to unwanted side effects, like setting permissons on /dev/stdout or for root setting permissions on /dev/null.
rust-highfive
commented
Mar 4, 2019
Contributor
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
haraldh
commented
Mar 4, 2019
ContributorAuthor
alexcrichton
commented
Mar 4, 2019
Member
Thanks! I wonder, could the logic here be shared between the two functions? |
haraldh
commented
Mar 4, 2019
ContributorAuthor
sure, we can extract the permission part in a helper function |
haraldh
commented
Mar 6, 2019
ContributorAuthor
waiting on #58803 to be merged for a refactored version |
haraldh
commented
Mar 6, 2019
ContributorAuthor
or should I force update #58803 with a new version? |
alexcrichton
commented
Mar 6, 2019
Member
Our queue is moving a bit slowly recently (sorry about that!) so want to go ahead and merge this with that PR? |
haraldh
commented
Mar 12, 2019
ContributorAuthor
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same fix as commit fb98ca7
PR: #58803
A convenience method like fs::copy() should try to prevent pitfalls a
normal user doesn't think about.
In case of an empty umask, setting the file mode early prevents
temporarily world readable or even writeable files,
because the default mode is 0o666.
In case the target is a named pipe or special device node, setting the
file mode can lead to unwanted side effects, like setting permissons on
/dev/stdout or for root setting permissions on /dev/null.