Uh oh!
There was an error while loading. Please reload this page.
Add hygiene machinery - #5908
Merged
Merged
Conversation
jbclements
commented
Apr 16, 2013
ContributorAuthor
Fooey. Needs rebase. Working on this... |
bors added a commit
that referenced
this pull request
Apr 18, 2013
This pull request changes the representation of identifiers by adding an integer to the side of each one. This integer will eventually be a reference to a side-table of syntax contexts, presumably stored in TLS. This pull request also adds a bunch of utility functions required for hygiene, and associated tests, but doesn't actually deploy those functions. Finally, it also has a number of small cleanup items.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 28, 2020
…=flip1995 Fix FP for `same_item_push` Fixesrust-lang/rust-clippy#5902 changelog: Fix FP for `same_item_push` where the pushed variable is mutated.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 9, 2020
Add changelog for 1.48 beta [Rendered](https://github.com/ebroto/rust-clippy/blob/changelog_1_48/CHANGELOG.md) I've not added the PRs fixing `same_item_push` because those were backported, namely: * [rust-lang#5908](rust-lang/rust-clippy#5908) * [rust-lang#5997](rust-lang/rust-clippy#5997) * [rust-lang#6016](rust-lang/rust-clippy#6016) The following PR was reverted, so I've ignored it too: * [rust-lang#5984](rust-lang/rust-clippy#5984) ~~Also, I took the liberty of adding a "Thanks" section, naming all the contributors to this release. I think they deserve visibility in the changelog. Please tell me if we want to add this or maybe it's redundant given we link to the PRs?~~ changelog: none r? `@flip1995`
calebcartwright pushed a commit
to calebcartwright/rust
that referenced
this pull request
Oct 23, 2023
* chore: Update clap * refactor(cargo): Update style of derive * feat(cargo): Style help like cargo nightly
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
5908: fmt import r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the representation of identifiers by adding an integer to the side of each one. This integer will eventually be a reference to a side-table of syntax contexts, presumably stored in TLS. This pull request also adds a bunch of utility functions required for hygiene, and associated tests, but doesn't actually deploy those functions.
Finally, it also has a number of small cleanup items.