Uh oh!
There was an error while loading. Please reload this page.
Fix issue #2626 by un-ignoring the mysterious test_leaks, - #5912
Closed
Dretch wants to merge 1 commit into
Closed
Conversation
which does currently seem to work on win32 (and linux).
bors added a commit
that referenced
this pull request
Apr 18, 2013
which does currently seem to work on win32 (and linux). Just mentioning issue #2626 again to make sure github picks it up.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 28, 2020
…nts, r=Manishearth,flip1995 Parse doctests in needless_doctest_main This switches from text-based search to running the parser to avoid false positives. Inspired by how [rustdoc](https://github.com/rust-lang/rust/blob/3f3250500fe152b5759c21453ba9a9129808d0d8/src/librustdoc/test.rs#L366) handles this and by rust-lang#4729. cc @llogiq changelog: Fix multiple false positives in [`needless_doctest_main`]. Fixesrust-lang#5879Fixesrust-lang#4906Fixesrust-lang#5103Fixesrust-lang#4698
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
5910: Fix some typos r=matklad a=SomeoneToIgnore 5912: Remove fixme from inlay_hints.ts r=matklad a=Veetaha I have reevaluated the fixme and it doesn't seem necessary to pass an array of files to the inlay hints request. This will (a) make the request more compilcated (b), make us wait for inlay hints for `all` active editors resolve at once before rendering and (c) doesn't seem required because 99% of the time there is a single active editor in the IDE Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: Veetaha <veetaha2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which does currently seem to work on win32 (and linux).
Just mentioning issue #2626 again to make sure github picks it up.