Skip to content

Update and clean up several parts of CONTRIBUTING.md - #59172

Merged
bors merged 8 commits into
rust-lang:masterfrom
varkor:contributing-contributions
Mar 23, 2019
Merged

Update and clean up several parts of CONTRIBUTING.md#59172
bors merged 8 commits into
rust-lang:masterfrom
varkor:contributing-contributions

Conversation

@varkor

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2019
@varkor

Copy link
Copy Markdown
ContributorAuthor

r? @steveklabnik

@TimNN

Copy link
Copy Markdown
Contributor

Ping from triage @steveklabnik: This PR requires you review.

@steveklabnik

Copy link
Copy Markdown
Contributor

Thanks for this!

@bors: r+ rollup

@bors

bors commented Mar 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 037596c has been approved by steveklabnik

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
…r=steveklabnik
Update and clean up several parts of CONTRIBUTING.md
@CentrilCentril mentioned this pull request Mar 19, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 22, 2019
…r=steveklabnik
Update and clean up several parts of CONTRIBUTING.md
Centril added a commit to Centril/rust that referenced this pull request Mar 22, 2019
…r=steveklabnik
Update and clean up several parts of CONTRIBUTING.md
@CentrilCentril mentioned this pull request Mar 22, 2019
bors added a commit that referenced this pull request Mar 22, 2019
Rollup of 18 pull requests
Successful merges:
- #59106 (Add peer_addr function to UdpSocket)
- #59170 (Add const generics to rustdoc)
- #59172 (Update and clean up several parts of CONTRIBUTING.md)
- #59190 (consistent naming for Rhs type parameter in libcore/ops)
- #59236 (Rename miri component to miri-preview)
- #59266 (Do not complain about non-existing fields after parse recovery)
- #59273 (some small HIR doc improvements)
- #59291 (Make Option<ThreadId> no larger than ThreadId, with NonZeroU64)
- #59297 (convert field/method confusion help to suggestions)
- #59304 (Move some bench tests back from libtest)
- #59309 (Add messages for different verbosity levels. Output copy actions.)
- #59321 (Unify E0109, E0110 and E0111)
- #59322 (Tweak incorrect escaped char diagnostic)
- #59323 (use suggestions for "enum instead of variant" error)
- #59327 (Add NAN test to docs)
- #59329 (cleanup: Remove compile-fail-fulldeps directory again)
- #59347 (Move one test from run-make-fulldeps to ui)
- #59360 (Add tracking issue number for `seek_convenience`)
Failed merges:
r? @ghost
@bors
bors merged commit 037596c into rust-lang:masterMar 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@varkor@rust-highfive@TimNN@steveklabnik@bors@Centril@nikomatsakis