Uh oh!
There was an error while loading. Please reload this page.
Fix custom relative libdir - #59341
Conversation
rust-highfive
commented
Mar 21, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
rust-highfive
commented
Mar 22, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
o01eg
commented
Mar 25, 2019
r? @Mark-Simulacrum Could you review this? |
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
One last nit but otherwise r=me
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Mar 25, 2019
@bors r+ |
bors
commented
Mar 25, 2019
📌 Commit 480510a863449eeed6ba81f1d9c80724f5daf78a has been approved by |
bors
commented
Mar 30, 2019
⌛ Testing commit 480510a863449eeed6ba81f1d9c80724f5daf78a with merge 87ea142e5c95a33b88d86607e94e84d4919d2b9d... |
bors
commented
Mar 30, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Mar 30, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r- |
I've just caught it myself after rebase: rust-fail.log.gz But somehow went missed in |
o01eg
commented
Mar 31, 2019
Looks like it fail because I joined image path with absolute libdir path which results in installation file into itself. |
rust-highfive
commented
Mar 31, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Uses relative libdir to place libraries on all stages. Adds verbose installation output.
o01eg
commented
Apr 1, 2019
Fixed failing. Could you re-review? |
Mark-Simulacrum
commented
Apr 1, 2019
@bors r+ Thanks! |
bors
commented
Apr 1, 2019
📌 Commit 5bcc365 has been approved by |
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
bors
commented
Apr 2, 2019
⌛ Testing commit 5bcc365 with merge 9969f9d7bef0ef54eac3311e69133fa6dacbdd15... |
bors
commented
Apr 2, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Apr 2, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
o01eg
commented
Apr 2, 2019
I've catched #58209 |
Mark-Simulacrum
commented
Apr 2, 2019
@bors retro |
Mark-Simulacrum
commented
Apr 2, 2019
@bors retry |
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
Rollup of 4 pull requests Successful merges: - #59166 (resolve: collect trait aliases along with traits) - #59341 (Fix custom relative libdir) - #59446 (Fix stack overflow when generating debuginfo for 'recursive' type) - #59529 (Added documentation on the remainder (Rem) operator for floating points.) Failed merges: r? @ghost
While working on #58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.