Uh oh!
There was an error while loading. Please reload this page.
Use consistent phrasing for all macro summaries - #59448
Conversation
rust-highfive
commented
Mar 26, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TimNN (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Mar 27, 2019
r? @Centril |
Centril
left a comment
There was a problem hiding this comment.
Looks great; r=me with green travis.
Centril
commented
Mar 28, 2019
@bors r+ rollup |
bors
commented
Mar 28, 2019
📌 Commit 3e0db7c has been approved by |
Use consistent phrasing for all macro summaries None
Rollup of 12 pull requests Successful merges: - #57987 (Fix some AArch64 typos) - #58581 (Refactor generic parameter encoder functions) - #58803 (fs::copy() unix: set file mode early) - #58848 (Prevent cache issues on version updates) - #59198 (Do not complain about unmentioned fields in recovered patterns) - #59351 (Include llvm-ar with llvm-tools component) - #59413 (HirIdify hir::ItemId) - #59441 (Remove the block on natvis for lld-link.) - #59448 (Use consistent phrasing for all macro summaries) - #59456 (Add documentation about `for` used as higher ranked trait bounds) - #59472 (Document that `std::io::BufReader` discards contents on drop) - #59474 (Fix link capitalization in documentation of std::io::BufWriter.) Failed merges: r? @ghost
No description provided.