Skip to content

fix: Make incremental artifact deletion more robust - #59449

Merged
bors merged 1 commit into
rust-lang:masterfrom
Marwes:issue_57958
Mar 28, 2019
Merged

fix: Make incremental artifact deletion more robust#59449
bors merged 1 commit into
rust-lang:masterfrom
Marwes:issue_57958

Conversation

@Marwes

Copy link
Copy Markdown
Contributor

Should fix the intermittent errors reported in #57958

cc #48614

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2019
@Mark-Simulacrum

Copy link
Copy Markdown
Member

r? @michaelwoerister

@michaelwoerister

Copy link
Copy Markdown
Member

Thanks @Marwes! That seems like a sensible thing to do.

@bors r+

@bors

bors commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit a365287 has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
fix: Make incremental artifact deletion more robust
Should fix the intermittent errors reported in rust-lang#57958
cc rust-lang#48614
@CentrilCentril mentioned this pull request Mar 27, 2019
cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019
fix: Make incremental artifact deletion more robust
Should fix the intermittent errors reported in rust-lang#57958
cc rust-lang#48614
@cuvipercuviper mentioned this pull request Mar 28, 2019
bors added a commit that referenced this pull request Mar 28, 2019
Rollup of 18 pull requests
Successful merges:
- #57293 (Make some lints incremental)
- #57565 (syntax: Remove warning for unnecessary path disambiguators)
- #58253 (librustc_driver => 2018)
- #58837 (librustc_interface => 2018)
- #59268 (Add suggestion to use `&*var` when `&str: From<String>` is expected)
- #59283 (Make ASCII case conversions more than 4× faster)
- #59284 (adjust MaybeUninit API to discussions)
- #59372 (add rustfix-able suggestions to trim_{left,right} deprecations)
- #59390 (Make `ptr::eq` documentation mention fat-pointer behavior)
- #59393 (Refactor tuple comparison tests)
- #59420 ([CI] record docker image info for reuse)
- #59421 (Reject integer suffix when tuple indexing)
- #59430 (Renames `EvalContext` to `InterpretCx`)
- #59439 (Generalize diagnostic for `x = y` where `bool` is the expected type)
- #59449 (fix: Make incremental artifact deletion more robust)
- #59451 (Add `Default` to `std::alloc::System`)
- #59459 (Add some tests)
- #59460 (Include id in Thread's Debug implementation)
Failed merges:
r? @ghost
@bors
bors merged commit a365287 into rust-lang:masterMar 28, 2019
@Marwes
Marwes deleted the issue_57958 branch April 23, 2020 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Marwes@rust-highfive@Mark-Simulacrum@michaelwoerister@bors@eddyb