Skip to content

Update rustc-guide submodule - #59595

Merged
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:update-rustc-guide
Apr 1, 2019
Merged

Update rustc-guide submodule#59595
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:update-rustc-guide

Conversation

@mark-i-m

Copy link
Copy Markdown
Contributor

Just keeping up with the head...

r? @steveklabnik

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2019
@ehuss

ehuss commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

@mark-i-m What is the story for this submodule? It is currently not published anywhere, which is a bit unusual.

I'm looking at updating the documentation every few weeks, and I can include this in the updates if you'd like. However, since I didn't see it being used, I wasn't sure what it was for.

@mark-i-m

Copy link
Copy Markdown
ContributorAuthor

@ehuss The plan is for toolstate to be used to check it, but I’ve pretty slow about implementing that. I just opened #59597... which should be a good first PR for someone.

Updating the docs every few weeks would be super helpful, especially when toolstate is in place.

@steveklabnik

Copy link
Copy Markdown
Contributor

It is currently not published anywhere, which is a bit unusual.

Yes, I thought that it was. My intention was to create a PR to start publishing it. I haven't gotten to it yet though.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Apr 1, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit abab4af has been approved by steveklabnik

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2019
@mark-i-m

Copy link
Copy Markdown
ContributorAuthor

Currently it is published via our own CI here: https://rust-lang.github.io/rustc-guide/

Centril added a commit to Centril/rust that referenced this pull request Apr 1, 2019
…eklabnik
Update rustc-guide submodule
Just keeping up with the head...
r? @steveklabnik
@CentrilCentril mentioned this pull request Apr 1, 2019
bors added a commit that referenced this pull request Apr 1, 2019
Rollup of 7 pull requests
Successful merges:
- #58507 (Add a -Z time option which prints only passes which runs once)
- #58919 (Suggest using anonymous lifetime in `impl Trait` return)
- #59041 (fixes#56766)
- #59586 (Fixed URL in cargotest::TEST_REPOS)
- #59595 (Update rustc-guide submodule)
- #59601 (Fix small typo)
- #59603 (stabilize ptr::hash)
Failed merges:
r? @ghost
@bors
bors merged commit abab4af into rust-lang:masterApr 1, 2019
@mark-i-m
mark-i-m deleted the update-rustc-guide branch May 25, 2019 02:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mark-i-m@rust-highfive@ehuss@steveklabnik@bors