Skip to content

Updated RELEASES.md for 1.34.0 - #59599

Merged
bors merged 3 commits into
rust-lang:masterfrom
XAMPPRocky:master
Apr 6, 2019
Merged

Updated RELEASES.md for 1.34.0#59599
bors merged 3 commits into
rust-lang:masterfrom
XAMPPRocky:master

Conversation

@XAMPPRocky

@XAMPPRockyXAMPPRocky commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

Rendered

This also corrects an omission in the previous 1.33.0 release.

r? @Mark-Simulacrum

cc @rust-lang/release

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2019
Centril
Centril suggested changes Apr 1, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Centril
Centril reviewed Apr 1, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to @steveklabnik & et. al -- I think these should be our headline items in order of importance (0. being most important) in the blog post.

Comment threadRELEASES.md Outdated

@CentrilCentrilApr 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadRELEASES.md Outdated

@CentrilCentrilApr 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadRELEASES.md Outdated

@CentrilCentrilApr 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadRELEASES.md Outdated

@CentrilCentrilApr 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tesuji
tesuji reviewed Apr 1, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
tormol
tormol reviewed Apr 1, 2019
View reviewed changes
Comment threadRELEASES.md
@kennytmkennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 1, 2019
@jonas-schievinkjonas-schievink added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Apr 1, 2019
@emilyalbiniemilyalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 2, 2019
@crlf0710

crlf0710 commented Apr 4, 2019

Copy link
Copy Markdown
Member

Out-of-topic: Speaking of targets, i think https://forge.rust-lang.org/platform-support.html has been out of date for quite a while... targets such as uefi have never been labeled a tier, and added to the table :(

@emilyalbini

emilyalbini commented Apr 5, 2019

Copy link
Copy Markdown
Member

Can we get this finished up for the release?

@Centril@XAMPPRocky
Update RELEASES.md
4ba3034
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
@Mark-Simulacrum

Mark-Simulacrum commented Apr 5, 2019

Copy link
Copy Markdown
Member

@bors r+

Not giving priority as it landing on beta is more important -- master can wait.

@bors

bors commented Apr 5, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 4ba3034 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
@Centril
Rollup merge ofrust-lang#59599- XAMPPRocky:master, r=Mark-Simulacrum
e025352
Updated RELEASES.md for 1.34.0
[Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md)
This also corrects an omission in the previous 1.33.0 release.
r? @Mark-Simulacrum
cc @rust-lang/release
@CentrilCentril mentioned this pull request Apr 5, 2019
Closed
@emilyalbiniemilyalbini mentioned this pull request Apr 5, 2019
Merged
@emilyalbiniemilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
@Centril
Rollup merge ofrust-lang#59599- XAMPPRocky:master, r=Mark-Simulacrum
2b90d67
Updated RELEASES.md for 1.34.0
[Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md)
This also corrects an omission in the previous 1.33.0 release.
r? @Mark-Simulacrum
cc @rust-lang/release
@CentrilCentril mentioned this pull request Apr 5, 2019
Merged
bors added a commit that referenced this pull request Apr 5, 2019
@bors
Auto merge of#59741- Centril:rollup-3us4b8q, r=Centril
05b4554
Rollup of 6 pull requests
Successful merges:
- #58894 (Fix invalid bounds string generation in rustdoc)
- #59599 (Updated RELEASES.md for 1.34.0)
- #59624 (SGX target: Use linker option to avoid code CGU assignment kludge)
- #59696 (Remove invalid assertion back::link::from add_upstream_rust_crates().)
- #59707 (Add missing tryfrom example)
- #59727 (wasi: Use shared API for preopened fds)
Failed merges:
r? @ghost
@bors
bors merged commit 4ba3034 into rust-lang:masterApr 6, 2019
bors added a commit that referenced this pull request Apr 7, 2019
@bors
Auto merge of#59737- pietroalbini:beta-rollup, r=pietroalbini
89b89b2
[beta] Rollup backports
Cherry-picked:
* #58021: Fix fallout from #57667
* #59599: Updated RELEASES.md for 1.34.0
* #59587: Remove #[doc(hidden)] from Error::type_id
* #58994: Hide deprecation warnings inside derive expansions
* #58015: Expand docs for `TryFrom` and `TryInto`.
* #59770: ci: pin android emulator to 28.0.23
* #59704: ci: Update FreeBSD tarball downloads
* #59257: Update CI configuration for building Redox libraries
* #59724: Function arguments should never get promoted
r? @ghost
bors added a commit that referenced this pull request Apr 8, 2019
@bors
Auto merge of#59737- pietroalbini:beta-rollup, r=pietroalbini
83cc9da
[beta] Rollup backports
Cherry-picked:
* #58021: Fix fallout from #57667
* #59599: Updated RELEASES.md for 1.34.0
* #59587: Remove #[doc(hidden)] from Error::type_id
* #58994: Hide deprecation warnings inside derive expansions
* #58015: Expand docs for `TryFrom` and `TryInto`.
* #59770: ci: pin android emulator to 28.0.23
* #59704: ci: Update FreeBSD tarball downloads
* #59257: Update CI configuration for building Redox libraries
* #59724: Function arguments should never get promoted
* #59499: Fix broken download link in the armhf-gnu image
* #58330: Add rustdoc JS non-std tests
* #58848: Prevent cache issues on version updates
r? @ghost
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuvipercuvipercuviper left review comments
+4 more reviewers
@CentrilCentrilCentril requested changes
@jonas-schievinkjonas-schievinkjonas-schievink left review comments
@tormoltormoltormol left review comments
@tesujitesujitesuji left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@XAMPPRocky@crlf0710@emilyalbini@Mark-Simulacrum@bors@cuviper@Centril@jonas-schievink@tormol@tesuji@kennytm@rust-highfive