Skip to content

Improvement for comparision against fn - #59798

Merged
bors merged 5 commits into
rust-lang:masterfrom
rchaser53:issue-59488
Apr 14, 2019
Merged

Improvement for comparision against fn#59798
bors merged 5 commits into
rust-lang:masterfrom
rchaser53:issue-59488

Conversation

@rchaser53

@rchaser53rchaser53 commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

I try to add error message.
related: #59488

@rust-highfive

rust-highfive commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2019
Centril
Centril reviewed Apr 8, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/op.rs Outdated
@petrochenkov

petrochenkov commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

r? @estebank

estebank
estebank reviewed Apr 9, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/op.rs
estebank
estebank reviewed Apr 11, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/op.rs Outdated
Comment threadsrc/librustc_typeck/check/op.rs
};

if self.lookup_op_method(fn_sig.output(),
&[other_ty],

@estebankestebankApr 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have another code branch for the case where both ty and other_ty are fns, so that you can suggest calling both of them, if their return types are the same.

Comment threadsrc/librustc_typeck/check/op.rs Outdated
Comment threadsrc/librustc_typeck/check/op.rs Outdated
@rchaser53

rchaser53 commented Apr 12, 2019

Copy link
Copy Markdown
ContributorAuthor

I reflected the estebank's review.

@estebank

estebank commented Apr 12, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d01ac0d has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2019
@bors

bors commented Apr 14, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d01ac0d with merge 464473a...

bors added a commit that referenced this pull request Apr 14, 2019
@bors
Auto merge of#59798- rchaser53:issue-59488, r=estebank
464473a
Improvement for comparision against fn
I try to add error message.
related: #59488
@bors

bors commented Apr 14, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing 464473a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2019
@bors
bors merged commit d01ac0d into rust-lang:masterApr 14, 2019
@rchaser53
rchaser53 deleted the issue-59488 branch April 14, 2019 08:59
@hellow554hellow554 mentioned this pull request Apr 18, 2019
Closed
@rchaser53rchaser53 mentioned this pull request Apr 18, 2019
Merged
@JohnTitorJohnTitor mentioned this pull request Apr 18, 2019
Closed
bors added a commit that referenced this pull request Apr 19, 2019
@bors
Auto merge of#60073- rchaser53:issue-60049, r=estebank
6c22051
avoid type-check body of DefId
fix: #60049
related: PR #59798
@estebankestebank mentioned this pull request Apr 25, 2019
Closed
@tesujitesuji mentioned this pull request Sep 29, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank left review comments
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@estebankestebank

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rchaser53@rust-highfive@petrochenkov@estebank@bors@Centril