Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #59868
Closed
sanxiyn wants to merge 23 commits into
Closed
Conversation
…n in the rustc book.
It is now exactly equivalent to lookup_char_pos.
This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy.
This adds some extra docs for the `no-prefer-dynamic` header. And also a `s/must_compile_successfully/compile_pass`. `must_compile_successfully` has been renamed to `compile_pass` at some point in the past and this comment was still referring to the old name.
- Make links relative. - Adjust links from old 2018-edition book. - Fix broken link in `let` docs.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
…ble compiler flags, instead of flags for debugging.
…mertj Document the -Z flag to the rustc book # Description Changes: - Added new documentation on the `-Z` flag of rustc in the command-line arguments section of the rustc book. If I need to rephrase anything or if you have any improvements, please let me know! I deliberately did not create an exhaustive list of all options since they are likely to change over time and per toolchain version. closesrust-lang#41142
remove lookup_char_pos_adj It is now exactly equivalent to lookup_char_pos.
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
compiletest: Improve no_prefer_dynamic docs This adds some extra docs for the `no-prefer-dynamic` header. And also a `s/must_compile_successfully/compile_pass`. `must_compile_successfully` has been renamed to `compile_pass` at some point in the past and this comment was still referring to the old name.
Kill dead code dominator code.
Hi,
Whilst fiddling around in the dominator code, I found some (I think) unused code. This code *was* used at the time it was imported, but over time it seems to have become redundant.
I've tested a build up to stage 1 with no problems. Maybe the tests will turn up something though.
P.S.
There is a FIXME comment in `dominators/mod.rs`:
```
pub fn is_dominated_by(&self, node: Node, dom: Node) -> bool {
// FIXME -- could be optimized by using post-order-rank
self.dominators(node).any(|n| n == dom)
}
```
I'm not sure of the intention of this comment. The `Dominators` struct already operates over post-order rank nodes. Any ideas?…sdreavus Fix broken links on std::boxed doc page r? @QuietMisdreavus
Fix links on keyword docs. - Make links relative. - Adjust links from old 2018-edition book. - Fix broken link in `let` docs.
Remove strange formatting in `Ordering` docs. I can't really fathom what the intent of the brackets is. The [original PR](rust-lang#12956) doesn't give any hints. I think it seems fine without them.
…acrum Re-export NonZero signed variant in std cc rust-lang#59834
std::ops::Div examples: correct nominator to numerator
sanxiyn
commented
Apr 11, 2019
ContributorAuthor
@bors p=10 |
sanxiyn
commented
Apr 11, 2019
ContributorAuthor
@bors r+ |
bors
commented
Apr 11, 2019
Collaborator
📌 Commit 83787bb has been approved by |
bors
commented
Apr 11, 2019
Collaborator
⌛ Testing commit 83787bb with merge f8133b3abcf8f1b52e6cd4768997be2d96bb24d1... |
bors
commented
Apr 11, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Apr 11, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
get_def_pathfrom Clippy #59779 (Upliftget_def_pathfrom Clippy)Orderingdocs. #59831 (Remove strange formatting inOrderingdocs.)Failed merges:
r? @ghost