Skip to content

Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std - #59908

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:str_escape
Apr 18, 2019
Merged

Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std#59908
bors merged 1 commit into
rust-lang:masterfrom
tesuji:str_escape

Conversation

@tesuji

@tesujitesuji commented Apr 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Apr 12, 2019

Copy link
Copy Markdown
Contributor

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2019
@tesuji

tesuji commented Apr 12, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @Mark-Simulacrum
@rustbot modify labels: +T-libs.

@rustbotrustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 12, 2019
@emilyalbini

emilyalbini commented Apr 12, 2019

Copy link
Copy Markdown
Member

cc @rust-lang/release
@rustbot modify labels: beta-nominated and stable-nominated.

@rustbotrustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Apr 12, 2019
@SimonSapin

SimonSapin commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

@pietroalbini what does stable-nominated mean? This change is low-risk, but definitely not worth making a 1.34.1 release on its own. (Unlike NonZeroI32 and friends, typical usage of these types does not require naming them: they are return types for inherent methods of str.)

@emilyalbini

emilyalbini commented Apr 16, 2019

Copy link
Copy Markdown
Member

Yep, it's not worth making a point release on its own, but there are also two beta regression ICEs that slipped in 1.34.0. The release team will decide if it's worth making a point release with this change and the two fixes in the meeting today (20:00 UTC, #release on discord).

@emilyalbini

emilyalbini commented Apr 16, 2019

Copy link
Copy Markdown
Member

@rust-lang/libs the release team agreed to release 1.34.1 on Thursday 25th, do you think this PR is safe to backport?

@SimonSapin

SimonSapin commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

Yes I would call it safe. But also of only small benefit in extremely niche situations.

@SimonSapin

SimonSapin commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

The libs team accepted backporting to beta in today’s triage meeting. However we feel that including this in the 1.34.1 release and in the accompanying blog post seems excessive, it’s not worth so much attention.

@SimonSapinSimonSapin added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 17, 2019
@SimonSapin

SimonSapin commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 2545867 has been approved by SimonSapin

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2019
@bors

bors commented Apr 17, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2545867 with merge 318cb64ea956093c50811a64423a112062587e3f...

Centril added a commit to Centril/rust that referenced this pull request Apr 17, 2019
@Centril
Rollup merge ofrust-lang#59908- lzutao:str_escape, r=SimonSapin
a204387
Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std
cc rust-lang#59893
@CentrilCentril mentioned this pull request Apr 17, 2019
Merged
@Centril

Centril commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

@bors retry

bors added a commit that referenced this pull request Apr 17, 2019
@bors
Auto merge of#60054- Centril:rollup-o40xxaa, r=Centril
9387927
Rollup of 4 pull requests
Successful merges:
- #59908 (Re-export core::str::{EscapeDebug, EscapeDefault, EscapeUnicode} in std)
- #59984 (Remove collection-specific `with_capacity` documentation from `std::collections`)
- #60036 (Remove nrc from toolstate pings)
- #60037 (Resolve inconsistency in error messages between "parameter" and "variable".)
Failed merges:
r? @ghost
@bors

bors commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2545867 with merge 9387927...

@bors
bors merged commit 2545867 into rust-lang:masterApr 18, 2019
@tesuji
tesuji deleted the str_escape branch April 18, 2019 06:48
@camelidcamelid mentioned this pull request Sep 19, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tesuji@rust-highfive@emilyalbini@SimonSapin@bors@Centril@aidanhs@Mark-Simulacrum@rustbot