Uh oh!
There was an error while loading. Please reload this page.
Update submodules (Clippy, RLS) - #59924
Merged
Merged
Conversation
rust-highfive
commented
Apr 12, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Apr 12, 2019
Contributor
|
Xanewok
commented
Apr 12, 2019
ContributorAuthor
bors
commented
Apr 12, 2019
Collaborator
📌 Commit fbe3dbc72fb924dccf83f25974ee71cb8ffbcbc0 has been approved by |
Xanewok
commented
Apr 12, 2019
ContributorAuthor
Based on #59901 (comment) and since #59733 is already being tested in the queue, I've omitted Miri for now @bors r+ |
bors
commented
Apr 12, 2019
Collaborator
📌 Commit c73486a967fa72772bc4a801c9c02c9f3ea457c5 has been approved by |
rust-highfive
commented
Apr 12, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
mati865
commented
Apr 12, 2019
Member
You don't have to update |
Xanewok
commented
Apr 12, 2019
ContributorAuthor
I'd like to avoid headache for someone that'd decide to update Miri together with rand (because of the rand_core:0.3.0 incompatibility) and hopefully that should the Miri update should follow very soon |
Xanewok
commented
Apr 12, 2019
ContributorAuthor
The linker error definitely looks unrelated unless I'm missing something obvious. Let's go for the minimal patch as you're saying |
Xanewok
commented
Apr 12, 2019
ContributorAuthor
@bors r+ |
bors
commented
Apr 12, 2019
Collaborator
📌 Commit 0a5bc93 has been approved by |
bors
commented
Apr 12, 2019
Collaborator
bors added a commit
that referenced
this pull request
Apr 12, 2019
Update submodules (Clippy, RLS) Basically #59916 with one fix applied to make it build
bors
commented
Apr 12, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
commented
Apr 13, 2019
Contributor
📣 Toolstate changed by #59924! Tested on commit 99da733. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 13, 2019
Tested on commit rust-lang/rust@99da733. Direct link to PR: <rust-lang/rust#59924> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra). 🎉 rls on windows: build-fail → test-pass (cc @nrc@Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-pass (cc @nrc@Xanewok, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically #59916 with one fix applied to make it build