Uh oh!
There was an error while loading. Please reload this page.
Bump bootstrap compiler to 2019-04-11 - #59974
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
emilyalbini
commented
Apr 14, 2019
r=me once travis is green |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3ff5330 to
707e330CompareCentril
commented
Apr 15, 2019
I bumped nightly to 1.36 but in the process I had to revert the @pietroalbini can you have another look? |
Mark-Simulacrum
commented
Apr 15, 2019
I expected a bunch more cfg's being removed; maybe I'm missing something? |
Mark-Simulacrum
commented
Apr 15, 2019
https://github.com/rust-lang/rust/blob/9cd61f025b1b92076e69a9ef2d9233325c7d8bdc/src/librustc/ty/mod.rs has an example of what I meant (I think that's actually the only case based on a quick search). |
EDIT: Rebased commit to remove accidental newline in With this commit it builds for me: |
Mark-Simulacrum
commented
Apr 15, 2019
r=me with that commit included |
Centril
commented
Apr 15, 2019
@bors r=pietroalbini,Mark-Simulacrum p=1 |
bors
commented
Apr 15, 2019
📌 Commit 72b2f23 has been approved by |
bors
commented
Apr 16, 2019
⌛ Testing commit 72b2f23 with merge 6f32d743e117c6d58b1d5de9c120e814094c40ec... |
bors
commented
Apr 16, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Apr 16, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
72b2f23 to
f2371e3CompareCentril
commented
Apr 17, 2019
@bors r=pietroalbini,Mark-Simulacrum p=1 |
bors
commented
Apr 17, 2019
📌 Commit f2371e3 has been approved by |
bors
commented
Apr 17, 2019
…,Mark-Simulacrum Bump bootstrap compiler to 2019-04-11 r? @pietroalbini cc @Mark-Simulacrum cc #58702
fortanix-bot
commented
Apr 17, 2019
bors
commented
Apr 17, 2019
☀️ Test successful - checks-travis, status-appveyor |
Keruspe
commented
Apr 25, 2019
nagisa
commented
Apr 25, 2019
A PR should be opened with the backported commit and auto-accepted since it simply fixes a technical mistake. |
Centril
commented
Apr 25, 2019
@Keruspe Can you file such a PR? |
Keruspe
commented
Apr 25, 2019
@Centril sure, will do |
r? @pietroalbini
cc @Mark-Simulacrum
cc #58702