Skip to content

Bump bootstrap compiler to 2019-04-11 - #59974

Merged
bors merged 6 commits into
rust-lang:masterfrom
Centril:boostrap-to-2019-04-11
Apr 17, 2019
Merged

Bump bootstrap compiler to 2019-04-11#59974
bors merged 6 commits into
rust-lang:masterfrom
Centril:boostrap-to-2019-04-11

Conversation

@Centril

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2019
@bors

This comment has been minimized.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2019
@bors

This comment has been minimized.

@bors

This comment has been minimized.

@emilyalbini

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@emilyalbini

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@emilyalbini

This comment has been minimized.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 14, 2019
@emilyalbini

Copy link
Copy Markdown
Member

r=me once travis is green

@ollie27

This comment has been minimized.

@Centril

This comment has been minimized.

@ollie27

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@Centril
Centrilforce-pushed the boostrap-to-2019-04-11 branch from 3ff5330 to 707e330CompareApril 15, 2019 02:51
@Centril

Copy link
Copy Markdown
ContributorAuthor

I bumped nightly to 1.36 but in the process I had to revert the #![cfg_attr(not(stage0), deny(internal))] => #![deny(internal)] changes because bumping to 1.36 combined with #![deny(internal)] broke the build for some reason...

@pietroalbini can you have another look?

@Mark-Simulacrum

Copy link
Copy Markdown
Member

I expected a bunch more cfg's being removed; maybe I'm missing something?

@Mark-Simulacrum

Copy link
Copy Markdown
Member

https://github.com/rust-lang/rust/blob/9cd61f025b1b92076e69a9ef2d9233325c7d8bdc/src/librustc/ty/mod.rs has an example of what I meant (I think that's actually the only case based on a quick search).

@mati865

mati865 commented Apr 15, 2019

Copy link
Copy Markdown
Member

EDIT: Rebased commit to remove accidental newline in src/librustc_mir/lib.rs.

With this commit it builds for me: e09e44a 5554af7eb9675b57542acad6e9426f800d221b67

@Mark-Simulacrum

Copy link
Copy Markdown
Member

r=me with that commit included

@Centril

Copy link
Copy Markdown
ContributorAuthor

@bors r=pietroalbini,Mark-Simulacrum p=1

@bors

bors commented Apr 15, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 72b2f23 has been approved by pietroalbini,Mark-Simulacrum

@borsbors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 15, 2019
@bors

bors commented Apr 16, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 72b2f23 with merge 6f32d743e117c6d58b1d5de9c120e814094c40ec...

@bors

bors commented Apr 16, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@rust-highfive

Copy link
Copy Markdown
Contributor

The job x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:03:03] Memory: 8 GB
[00:03:03] Boot ROM Version: VMW71.00V.7581552.B64.1801142334
[00:03:03] Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:03] SMC Version (system): 2.8f0
[00:03:03] Serial Number (system): VM3YNTVIHx5E
[00:03:03] [00:03:03] hw.ncpu: 4
[00:03:03] hw.byteorder: 1234
[00:03:03] hw.memsize: 8589934592
---
[01:15:23] Compiling rustfix v0.4.4
[01:15:25] [RUSTC-TIMING] rustfix test:false 1.985
[01:15:25] Compiling compiletest v0.0.0 (/Users/travis/build/rust-lang/rust/src/tools/compiletest)
[01:15:26] error: the item `libc` is imported redundantly
[01:15:26] --> src/tools/compiletest/src/raise_fd_limit.rs:10:9
[01:15:26] 10 | use libc;
[01:15:26] | ^^^^
[01:15:26] | [01:15:26] ::: src/tools/compiletest/src/main.rs:7:1
[01:15:26] ::: src/tools/compiletest/src/main.rs:7:1
[01:15:26] |
[01:15:26] 7 | extern crate libc;
[01:15:26] | ------------------ the item `libc` is already imported here
[01:15:26] |
[01:15:26] note: lint level defined here
[01:15:26] --> src/tools/compiletest/src/main.rs:4:9
[01:15:26] |
[01:15:26] 4 | #![deny(warnings, rust_2018_idioms)]
[01:15:26] = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[01:15:26] [01:15:27] error: aborting due to previous error
[01:15:27] ---
[01:15:27] command did not execute successfully: "/Users/travis/build/rust-lang/rust/build/x86_64-apple-darwin/stage0/bin/cargo" "build" "--target" "x86_64-apple-darwin" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/Users/travis/build/rust-lang/rust/src/tools/compiletest/Cargo.toml" "--message-format" "json"
[01:15:27] expected success, got: exit code: 101
[01:15:27] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap test
[01:15:27] Build completed unsuccessfully in 0:01:52
[01:15:27] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0ab58916
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Apr 16 16:03:05 GMT 2019
---
travis_fold:start:after_failure.2
travis_time:start:2e6dac70
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis staff 510 Jan 25 2018 ..
drwx------ 2 travis staff 68 Dec 6 2017 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:01a5b24d
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:01a5b24d:start=1555430589271268000,finish=1555430589302492000,duration=31224000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0019f2f7
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:20fb8766
travis_time:start:20fb8766
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2b3091fa
$ dmesg | grep -i kill
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.6
Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2019
@Centril
Centrilforce-pushed the boostrap-to-2019-04-11 branch from 72b2f23 to f2371e3CompareApril 17, 2019 03:46
@Centril

Copy link
Copy Markdown
ContributorAuthor

@bors r=pietroalbini,Mark-Simulacrum p=1

@bors

bors commented Apr 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f2371e3 has been approved by pietroalbini,Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2019
@bors

bors commented Apr 17, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f2371e3 with merge 258e3b3...

bors added a commit that referenced this pull request Apr 17, 2019
@fortanix-bot

Copy link
Copy Markdown

Build failed for target x86_64-fortanix-unknown-sgx - status

cc @jethrogb

@bors

bors commented Apr 17, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini,Mark-Simulacrum
Pushing 258e3b3 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 17, 2019
@bors
bors merged commit f2371e3 into rust-lang:masterApr 17, 2019
@Centril
Centril deleted the boostrap-to-2019-04-11 branch April 17, 2019 07:08
@CentrilCentril mentioned this pull request Apr 17, 2019
@Keruspe

Copy link
Copy Markdown
Contributor

@Centrild6cc855 should be backported to beta in order to fix #60265

@nagisa

Copy link
Copy Markdown
Member

A PR should be opened with the backported commit and auto-accepted since it simply fixes a technical mistake.

@Centril

Copy link
Copy Markdown
ContributorAuthor

@Keruspe Can you file such a PR?

@Keruspe

Copy link
Copy Markdown
Contributor

@Centril sure, will do

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@Centril@bors@emilyalbini@rust-highfive@ollie27@Mark-Simulacrum@mati865@fortanix-bot@Keruspe@nagisa