Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #59991
Merged
Merged
Conversation
This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy.
Add must_use annotations to Result::is_ok and is_err Discussed in rust-lang#59610
Add summary and reference to Rust trademark guide Fixrust-lang#53287 cc @steveklabnik
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent I made `intra_doc_link_resolution_failure` warn so that it would properly respect `deny-warnings = false` in `config.toml`. `#[warn]` still become errors with `-D warnings` so I thought this was fine. Turns out however that we don't pass `-D warnings` when running rustdoc, so for additional rustdoc-lints we need to set them to `deny`. Also sue the opportunity to make the lint flags more consistent between libcore, liballoc, libstd. Cc @gnzlbg for the *big* stdsimd update.
…dreavus rustdoc: Remove default keyword from re-exported trait methods Fixesrust-lang#59977 r? @QuietMisdreavus As this fixes a stable to beta regression, could it be backported?
Fix links to Atomic* in RELEASES.md
Centril
commented
Apr 15, 2019
ContributorAuthor
@bors r+ p=6 |
bors
commented
Apr 15, 2019
Collaborator
📌 Commit 6434fe9 has been approved by |
bors
commented
Apr 15, 2019
Collaborator
bors added a commit
that referenced
this pull request
Apr 15, 2019
Rollup of 6 pull requests Successful merges: - #59648 (Add must_use annotations to Result::is_ok and is_err) - #59748 (Add summary and reference to Rust trademark guide) - #59779 (Uplift `get_def_path` from Clippy) - #59955 (bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent) - #59978 (rustdoc: Remove default keyword from re-exported trait methods) - #59989 (Fix links to Atomic* in RELEASES.md) Failed merges: r? @ghost
bors
commented
Apr 15, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
get_def_pathfrom Clippy #59779 (Upliftget_def_pathfrom Clippy)Failed merges:
r? @ghost