Skip to content

Feature gate async methods - #60088

Merged
bors merged 8 commits into
rust-lang:masterfrom
varkor:async_await-method-feature-gate
Apr 21, 2019
Merged

Feature gate async methods#60088
bors merged 8 commits into
rust-lang:masterfrom
varkor:async_await-method-feature-gate

Conversation

@varkor

@varkorvarkor commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

Fixes#60069.

@rust-highfive

rust-highfive commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2019
@cramertj

cramertj commented Apr 18, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@bors r+
@bors r? @cramertj

@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

bors commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit edce367 has been approved by cramertj

@cramertj

cramertj commented Apr 18, 2019

Copy link
Copy Markdown
Member

@bors r? @cramertj

@cramertjcramertj mentioned this pull request Apr 18, 2019
Closed
@CentrilCentril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge ofrust-lang#60088- varkor:async_await-method-feature-g…
f7ffa06
…ate, r=cramertj
Feature gate async methods
Fixesrust-lang#60069.
@rust-highfive

This comment has been minimized.

Sign in to view
@varkor

varkor commented Apr 18, 2019

Copy link
Copy Markdown
ContributorAuthor

(Forgot to re---bless after fixing a typo.)

@bors r=cramertj

@bors

bors commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 3dbe05f has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge ofrust-lang#60088- varkor:async_await-method-feature-g…
e3264bb
…ate, r=cramertj
Feature gate async methods
Fixesrust-lang#60069.
@CentrilCentril mentioned this pull request Apr 18, 2019
Closed
@varkor

varkor commented Apr 18, 2019

Copy link
Copy Markdown
ContributorAuthor

async fn isn't valid in trait methods at the moment, but I realised the existing feature gate was missing a test, so I've added one just to make certain we don't accidentally stabilise something we don't want to.

@bors r=cramertj

@bors

bors commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 7548ca6 has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge ofrust-lang#60088- varkor:async_await-method-feature-g…
22d9083
…ate, r=cramertj
Feature gate async methods
Fixesrust-lang#60069.
@CentrilCentril mentioned this pull request Apr 18, 2019
Closed
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril

Centril commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

@bors r-

@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 18, 2019
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge ofrust-lang#60088- varkor:async_await-method-feature-g…
d6fd895
…ate, r=cramertj
Feature gate async methods
Fixesrust-lang#60069.
@CentrilCentril mentioned this pull request Apr 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge ofrust-lang#60088- varkor:async_await-method-feature-g…
8ba6c29
…ate, r=cramertj
Feature gate async methods
Fixesrust-lang#60069.
@CentrilCentril mentioned this pull request Apr 19, 2019
Closed
@Centril

Centril commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

Failed in #60100 (comment), @bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2019
@lnicola

lnicola commented Apr 19, 2019

Copy link
Copy Markdown
Member
[00:55:59] - Some errors occurred: E0223, E0599.
[00:55:59] + Some errors have detailed explanations: E0223, E0599.

Looks like the error message needs to be updated for #60046?

@varkor
varkorforce-pushed the async_await-method-feature-gate branch from bf0965c to ee49605CompareApril 20, 2019 21:32
@varkor

varkor commented Apr 20, 2019

Copy link
Copy Markdown
ContributorAuthor

@lnicola: thanks!

@bors r=cramertj

@bors

bors commented Apr 20, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit ee49605 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 20, 2019
@bors

bors commented Apr 20, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ee49605 with merge c3a7194...

bors added a commit that referenced this pull request Apr 20, 2019
@bors
Auto merge of#60088- varkor:async_await-method-feature-gate, r=cram…
c3a7194
…ertj
Feature gate async methods
Fixes#60069.
@bors

bors commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: cramertj
Pushing c3a7194 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2019
@bors
bors merged commit ee49605 into rust-lang:masterApr 21, 2019
This was referenced Apr 21, 2019
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cramertjcramertj

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can define and use async fn without feature gate on nightly

7 participants

@varkor@rust-highfive@cramertj@bors@Centril@lnicola@petrochenkov