Uh oh!
There was an error while loading. Please reload this page.
Rollup of 15 pull requests - #60101
Closed
Centril wants to merge 39 commits into
Closed
Conversation
Stack size of 10 **bytes** does not make any sense: the minimal possible stack size is greater anyway.
…C_ to make things clearer.
The documentation for `rchunks_exact` said it started at the beginning of the slice, bit it actually starts at the end of the slice. In addition, there were a couple of "of the slice of the slice" duplicate phrases going on for `rchunks_exact` and `rchunks_exact_mut`. This fixesrust-lang#60068.
… clean up some run-make tests.
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
Make clear that format padding doesn't work for Debug As mentioned in rust-lang#46006 (comment)
implement specialized nth_back() for Bytes, Fuse and Enumerate Hi, After my first PR has been successfully merged, here is my second pull request :-) Also this PR contains some specializations for the problem discussed in rust-lang#54054.
…r=QuietMisdreavus Remove unwanted z-index change Fixesrust-lang#60031. r? @QuietMisdreavus
…lexcrichton Add codegen test for PGO instrumentation. This PR adds a codegen test that makes sure that LLVM actually generates instrumentation code when we enable PGO instrumentation in `rustc`. The second commit updates a test case to the new commandline option syntax introduced in rust-lang#59874. Without the fix the test still works, but it confusingly creates a directory called `test.profraw`, which usually is the name of the _file_ where profiling data is collected.
Simplify the returning of a Result a bit
… r=estebank Correct unused parameter diagnostic The message was incorrect for unused lifetime parameters. There's no need to be specific.
…ichton Update rustfmt to 1.2.1
whitelist RTM x86 target cpu feature This PR adds support for intels restricted transactional memory cpu feature. I mostly copied what was done for the [movbe](rust-lang#57999) feature. rust-lang/stdarch#718
Point at try `?` on errors affecting the err match arm of the desugared code Fixrust-lang#59980.
Use more realistic example for thread builder Stack size of 10 **bytes** does not make any sense: the minimal possible stack size is greater anyway.
Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`. The documentation for `rchunks_exact` said it started at the beginning of the slice, bit it actually starts at the end of the slice. In addition, there were a couple of "of the slice of the slice" duplicate phrases going on for `rchunks_exact` and `rchunks_exact_mut`. This fixesrust-lang#60068.
…, r=rkruppe Use -mergefunc-use-aliases for any LLVM >= 8 This functionality is not specific to Rust's LLVM, but any starting in LLVM 8.0, as noted in <rust-lang#56358 (comment)>. cc @nikic r? @rkruppe
libcore: deny `elided_lifetimes_in_paths` r? @varkor
Centril
commented
Apr 19, 2019
ContributorAuthor
@bors r+ p=15 |
bors
commented
Apr 19, 2019
Collaborator
📌 Commit 0a5fe40 has been approved by |
bors
commented
Apr 19, 2019
Collaborator
⌛ Testing commit 0a5fe40 with merge 841963e0df7cf0f4331282eb8c1cca55bf85e634... |
bors
commented
Apr 19, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Apr 19, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
?on errors affecting the err match arm of the desugared code #60064 (Point at try?on errors affecting the err match arm of the desugared code)rchunks_exactandrchunks_exact_mut. #60080 (Fix small errors in docs forrchunks_exactandrchunks_exact_mut.)elided_lifetimes_in_paths#60098 (libcore: denyelided_lifetimes_in_paths)Failed merges:
r? @ghost