Skip to content

Continue evaluating after item-type checking - #60126

Merged
bors merged 3 commits into
rust-lang:masterfrom
estebank:continue-eval
Apr 23, 2019
Merged

Continue evaluating after item-type checking#60126
bors merged 3 commits into
rust-lang:masterfrom
estebank:continue-eval

Conversation

@estebank

@estebankestebank commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2019
Centril
Centril reviewed Apr 20, 2019
View reviewed changes
Comment threadsrc/test/ui/infinite/infinite-tag-type-recursion.stderr Outdated

@CentrilCentrilApr 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note doesn't seem like something the user would understand... :)

@estebankestebankApr 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't. There hard error removal is causing some spurious and duplicated errors that I want to hide, but for now I want to put these changes out asap so that's we can capture any lurking ICEs.

@oli-obkoli-obkApr 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a lot of cycle errors without comprehensible diagnostics. This is something that needs to be addressed in general and is not specific to this PR

@estebankestebankApr 22, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #60178

oli-obk
oli-obk requested changes Apr 20, 2019
View reviewed changes
Comment threadsrc/test/ui/c-variadic/variadic-ffi-1.rs Outdated
Comment threadsrc/test/ui/infinite/infinite-tag-type-recursion.stderr Outdated

@oli-obkoli-obkApr 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a lot of cycle errors without comprehensible diagnostics. This is something that needs to be addressed in general and is not specific to this PR

Comment threadsrc/test/ui/rfc-1937-termination-trait/termination-trait-test-wrong-type.rs Outdated
Comment threadsrc/test/ui/structs/struct-base-wrong-type.rs Outdated
@oli-obk

oli-obk commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

Just some nits. This is definitely a great improvement, the two problems discovered are preexisting and should be addressed independently. Please open issues about them.

r=me with the above

@estebankestebank mentioned this pull request Apr 22, 2019
Closed
@estebank

estebank commented Apr 22, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=oli-obk

@bors

bors commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 2dc5d52 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2019
@bors

bors commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2dc5d52 with merge 004c549...

bors added a commit that referenced this pull request Apr 22, 2019
@bors
Auto merge of#60126- estebank:continue-eval, r=oli-obk
004c549
Continue evaluating after item-type checking
Fix#30999.
r? @oli-obk
@bors

bors commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 004c549 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 23, 2019
@bors
bors merged commit 2dc5d52 into rust-lang:masterApr 23, 2019
@dwrenshadwrensha mentioned this pull request Mar 1, 2020
Closed
estebank added a commit to estebank/rust that referenced this pull request Mar 1, 2020
@estebank
delay_span_bug when codegen cannot select obligation
7b6f5ed
Fixrust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past
type checking after encountering errors.
@estebankestebank mentioned this pull request Mar 1, 2020
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
@JohnTitor
Rollup merge ofrust-lang#69614- estebank:ice-age, r=davidtwco
e067bf4
`delay_span_bug` when codegen cannot select obligation
Fixrust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past
type checking after encountering errors.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
@JohnTitor
Rollup merge ofrust-lang#69614- estebank:ice-age, r=davidtwco
273c5b2
`delay_span_bug` when codegen cannot select obligation
Fixrust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past
type checking after encountering errors.
bors added a commit that referenced this pull request Mar 6, 2020
@bors
Auto merge of#69614- estebank:ice-age, r=davidtwco
865b44a
`delay_span_bug` when codegen cannot select obligation
Fix#69602, introduced in #60126 by letting the compiler continue past
type checking after encountering errors.
@estebankestebank mentioned this pull request Mar 6, 2020
Open
@steffahnsteffahn mentioned this pull request Apr 9, 2020
Closed
@tesujitesuji mentioned this pull request Oct 14, 2020
Closed
@SNCPlay42SNCPlay42 mentioned this pull request Nov 26, 2020
Closed
@estebank
estebank deleted the continue-eval branch November 9, 2023 05:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk requested changes
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obkoli-obk

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error E0046 should be the last one to report

5 participants

@estebank@oli-obk@bors@Centril@rust-highfive