Skip to content

Fix broken link in rustc_plugin doc - #60131

Merged
bors merged 1 commit into
rust-lang:masterfrom
agnxy:doc-link
May 6, 2019
Merged

Fix broken link in rustc_plugin doc#60131
bors merged 1 commit into
rust-lang:masterfrom
agnxy:doc-link

Conversation

@agnxy

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2019
Comment threadsrc/librustc_plugin/lib.rs
@tesuji

Copy link
Copy Markdown
Contributor

r? @Centril

@Centril

Copy link
Copy Markdown
Contributor

I don't know what the policy around linking is; r? @ehuss

@Centril

Copy link
Copy Markdown
Contributor

@bors delegate=ehuss

@bors

bors commented Apr 29, 2019

Copy link
Copy Markdown
Collaborator

✌️ @ehuss can now approve this pull request

@ehuss

ehuss commented May 4, 2019

Copy link
Copy Markdown
Contributor

Considering that these aren't distributed with rustup (AFAIK), and that these are only published on nightly, I'm inclined to just use the full https link. In the rare case someone is working offline, I think they'll be able to figure out what to do.

@bors r+

@bors

bors commented May 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f77b602 has been approved by ehuss

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2019
@ehuss

ehuss commented May 4, 2019

Copy link
Copy Markdown
Contributor

@bors rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request May 5, 2019
@ManishearthManishearth mentioned this pull request May 5, 2019
bors added a commit that referenced this pull request May 5, 2019
Rollup of 5 pull requests
Successful merges:
- #60131 (Fix broken link in rustc_plugin doc)
- #60426 (Stop `-O`/`-C opt-level` and `-g`/`-C debuginfo` conflicting)
- #60515 (use span instead of div for since version)
- #60530 (rustc: rename all occurences of "freevar" to "upvar".)
- #60536 (Correct code points to match their textual description)
Failed merges:
r? @ghost
@bors
bors merged commit f77b602 into rust-lang:masterMay 6, 2019
@agnxy
agnxy deleted the doc-link branch May 6, 2019 13:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link to unstable book in rustc_plugin API docs

7 participants

@agnxy@tesuji@Centril@bors@ehuss@steveklabnik@rust-highfive