Uh oh!
There was an error while loading. Please reload this page.
Warn when ignore-tidy-linelength is present, but no lines are too long - #60169
Merged
Conversation
rust-highfive
commented
Apr 22, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
varkor
commented
Apr 22, 2019
ContributorAuthor
r? @kennytm |
kennytm
reviewed
Apr 22, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
varkorforce-pushed
the
tidy-unnecessary-ignore-newline
branch
from
April 22, 2019 15:42
6a6400a to
1da5d9dComparekennytm
commented
Apr 22, 2019
Member
r=me after Travis passes. |
petrochenkov
commented
Apr 22, 2019
Contributor
This kind of logic is applicable to all tidy rules.
|
bors
commented
Apr 22, 2019
Collaborator
☔ The latest upstream changes (presumably #60168) made this pull request unmergeable. Please resolve the merge conflicts. |
varkorforce-pushed
the
tidy-unnecessary-ignore-newline
branch
from
April 22, 2019 19:58
25fb915 to
c2895a5Comparevarkor
commented
Apr 22, 2019
ContributorAuthor
@kennytm: I've updated the PR to also warn when other tidy ignore directives are present, but have no effect. Could you check to make sure the changes are still okay? |
kennytm
commented
Apr 23, 2019
Member
@bors r+ |
bors
commented
Apr 23, 2019
Collaborator
📌 Commit c2895a5 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Apr 23, 2019
…ine, r=kennytm Warn when ignore-tidy-linelength is present, but no lines are too long It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
Member
@bors r- This PR failed in the rollup #60189, because #60172 has accidentally removed the CRLF line endings from src/test/run-pass/issues/issue-16278.rs (see #16278). They need to be added back. (Congratulations in detecting a regression? 🙃)
|
varkor
commented
Apr 23, 2019
ContributorAuthor
varkorforce-pushed
the
tidy-unnecessary-ignore-newline
branch
from
April 23, 2019 11:19
c2895a5 to
5ab5806Comparevarkor
commented
Apr 23, 2019
ContributorAuthor
@bors r=kennytm |
bors
commented
Apr 23, 2019
Collaborator
📌 Commit 5ab5806 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 23, 2019
…ine, r=kennytm Warn when ignore-tidy-linelength is present, but no lines are too long It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 23, 2019
…ine, r=kennytm Warn when ignore-tidy-linelength is present, but no lines are too long It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 23, 2019
…ine, r=kennytm Warn when ignore-tidy-linelength is present, but no lines are too long It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 23, 2019
…ine, r=kennytm Warn when ignore-tidy-linelength is present, but no lines are too long It's easy for a `// ignore-tidy-linelength` to be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces `// ignore-tidy-linelength` to be used exactly when necessary, to make sure such changes are intentional.
bors added a commit
that referenced
this pull request
Apr 23, 2019
Rollup of 6 pull requests Successful merges: - #59823 ([wg-async-await] Drop `async fn` arguments in async block ) - #59839 (Warn on unused results for operation methods on nums) - #60146 (Update fonts used by rustdoc) - #60169 (Warn when ignore-tidy-linelength is present, but no lines are too long) - #60177 (Promote rust comments to rustdoc) - #60191 (Add f16c target_feature) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's easy for a
// ignore-tidy-linelengthto be added when there is a genuine need to ignore a file's line length, but then after refactoring the need is gone, but the tidy directive is not removed. This means that in the future, further editing may accidentally add unnecessarily long lines. This change forces// ignore-tidy-linelengthto be used exactly when necessary, to make sure such changes are intentional.