Skip to content

Use -Zborrowck=mir for NLL compare mode - #60171

Merged
bors merged 2 commits into
rust-lang:masterfrom
matthewjasper:full-nll-compare-mode
May 17, 2019
Merged

Use -Zborrowck=mir for NLL compare mode#60171
bors merged 2 commits into
rust-lang:masterfrom
matthewjasper:full-nll-compare-mode

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@matthewjaspermatthewjasper mentioned this pull request Apr 28, 2019
Closed
@matthewjasper
matthewjasperforce-pushed the full-nll-compare-mode branch 2 times, most recently from 049c4c9 to 8fa44c0CompareMay 4, 2019 11:35
@matthewjasper
matthewjasperforce-pushed the full-nll-compare-mode branch from 8fa44c0 to be5fe05CompareMay 12, 2019 18:51
@pnkfelixpnkfelix mentioned this pull request May 12, 2019
Closed
@pnkfelix

pnkfelix commented May 13, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Sorry its taken me so long to take a look at this.

@matthewjasper , did you already manually review those new .nll.stderr's? I started looking through them, but its too many to do via Github interface in a single review. And I'm basically wondering whether we need to plan for a new round of going over all of the diffs between the .stderr and .nll.stderr files.

@matthewjasper

matthewjasper commented May 13, 2019

Copy link
Copy Markdown
ContributorAuthor

I checked that there was nothing completely unexpected, but an actual review is needed.

@pnkfelix

pnkfelix commented May 17, 2019

Copy link
Copy Markdown
Contributor

Okay.

I think our best bet is to land this, and then do a review in an incremental fashion as a follow-up task.

@pnkfelix

pnkfelix commented May 17, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit be5fe05 has been approved by pnkfelix

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2019
@pnkfelix

pnkfelix commented May 17, 2019

Copy link
Copy Markdown
Contributor

(the PR is probably out of date, but I'll just let bors tell us if that's true.)

@bors

bors commented May 17, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit be5fe05 with merge b982867...

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of#60171- matthewjasper:full-nll-compare-mode, r=pnkfelix
b982867
Use -Zborrowck=mir for NLL compare mode
closes#56993
r? @pnkfelix
@bors

bors commented May 17, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: pnkfelix
Pushing b982867 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2019
@bors
bors merged commit be5fe05 into rust-lang:masterMay 17, 2019
This was referenced May 17, 2019
Merged
Merged
@matthewjasper
matthewjasper deleted the full-nll-compare-mode branch July 29, 2019 19:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

region tests incorrectly passing with NLL enabled

4 participants

@matthewjasper@pnkfelix@bors@rust-highfive