[stable] 1.34.1 point release by emilyalbini · Pull Request #60198 · rust-lang/rust

emilyalbini · 2019-04-23T14:24:07Z

The release date is April 25th.

Included in this point release:

Fix the link to sort_by_cached_key #59891: Fix the link to sort_by_cached_key
Fix links to Atomic* in RELEASES.md #59989: Fix links to Atomic* in RELEASES.md
Fix ICE #3747 rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
do not trigger redundant_closure when there is a difference in borrow… rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
Fix two missing_const_for_fn false positives rust-clippy#3844: Fix two missing_const_for_fn false positives

rust-highfive · 2019-04-23T14:24:19Z

⚠️Warning⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!
These commits modify submodules.

jonas-schievink · 2019-04-23T15:25:49Z

Would be nice to include the stable-accepted release notes fixes as well:

It's a primitive slice method, not a standalone function.

emilyalbini · 2019-04-23T16:07:43Z

Good catch, added!

Mark-Simulacrum · 2019-04-23T20:32:03Z

@bors r+ p=1000

bors · 2019-04-23T20:32:04Z

📌 Commit 34aed3d has been approved by Mark-Simulacrum

bors · 2019-04-23T22:39:46Z

⌛ Testing commit 34aed3d with merge 51a0553fd41238b8a723b858c97ff7932acf189e...

bors · 2019-04-24T00:20:43Z

💔 Test failed - status-appveyor

emilyalbini · 2019-04-24T08:31:27Z

Eeek?

@bors retry

bors · 2019-04-24T09:02:25Z

⌛ Testing commit 34aed3d with merge bb9f4bfb6497da2cfe2fb37a163caa8810a00d71...

jonas-schievink · 2019-04-24T09:49:12Z

ImportError: No module named lldb

I had a similar error when running the tests on Arch Linux, for me the solution was to uninstall the system's LLDB. Not sure why this suddenly popped up on AppVeyor though.

emilyalbini · 2019-04-24T11:01:15Z

Wtf? AppVeyor wasn't scheduled.

@bors retry

emilyalbini · 2019-04-24T13:36:26Z

@bors treeclosed-

AppVeyor said to have fixed the issue.

bors · 2019-04-24T13:37:22Z

⌛ Testing commit 34aed3d with merge 3ea00c5...

[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors · 2019-04-24T15:19:48Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2019-04-24T19:07:03Z

Appveyor updated their build images on April 14th, which involved an LLVM upgrade (to 8) and Python upgrades: https://www.appveyor.com/updates/2019/04/14/. With the theory that this might be responsible for our troubles, I've pushed a commit downgrading to the "previous" image.

@bors r+

bors · 2019-04-24T19:07:04Z

📌 Commit 9a8268e has been approved by Mark-Simulacrum

bors · 2019-04-24T19:09:32Z

⌛ Testing commit 9a8268e with merge 89a3797...

[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors · 2019-04-24T20:47:22Z

💔 Test failed - status-appveyor

jethrogb · 2019-04-24T20:54:54Z

Same failure as before

emilyalbini · 2019-04-24T21:04:32Z

I think the image: yaml key has to be at the top level, not inside environment:.

@bors r=Mark-Simulacrum p=1000

bors · 2019-04-24T21:04:33Z

📌 Commit d8a026d has been approved by Mark-Simulacrum

[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors · 2019-04-24T21:05:06Z

⌛ Testing commit d8a026d with merge fc50f32...

fortanix-bot · 2019-04-24T21:48:06Z

Build failed for target x86_64-fortanix-unknown-sgx - status

cc @jethrogb

bors · 2019-04-25T00:53:21Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing fc50f32 to stable...

rust-highfive assigned Mark-Simulacrum Apr 23, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2019

cuviperand others added 5 commits April 23, 2019 18:06

Fix the link to sort_by_cached_key
edada61
It's a primitive slice method, not a standalone function.

Fix links to Atomic* in RELEASES.md
2a65561

update clippy
78c88a1

update release notes for 1.34.1
e283c52

bump to rust 1.34.1
34aed3d

emilyalbini force-pushed the stable-next branch from 36b625e to 34aed3dCompare April 23, 2019 16:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2019

Try previous build image on AppVeyor
d8a026d

emilyalbini force-pushed the stable-next branch from 9a8268e to d8a026dCompare April 24, 2019 21:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2019

bors merged commit d8a026d into rust-lang:stableApr 25, 2019

Uh oh!

Uh oh!

Conversation

emilyalbini commented Apr 23, 2019• edited by Mark-Simulacrum Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Apr 23, 2019

Uh oh!

jonas-schievink commented Apr 23, 2019

Uh oh!

emilyalbini commented Apr 23, 2019

Uh oh!

Mark-Simulacrum commented Apr 23, 2019

Uh oh!

bors commented Apr 23, 2019

Uh oh!

bors commented Apr 23, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Apr 24, 2019

Uh oh!

emilyalbini commented Apr 24, 2019

Uh oh!

bors commented Apr 24, 2019

Uh oh!

This comment has been minimized.

jonas-schievink commented Apr 24, 2019

Uh oh!

emilyalbini commented Apr 24, 2019

Uh oh!

emilyalbini commented Apr 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Apr 24, 2019

Uh oh!

This comment has been minimized.

bors commented Apr 24, 2019

Uh oh!

Mark-Simulacrum commented Apr 24, 2019

Uh oh!

bors commented Apr 24, 2019

Uh oh!

bors commented Apr 24, 2019

Uh oh!

This comment has been minimized.

bors commented Apr 24, 2019

Uh oh!

jethrogb commented Apr 24, 2019

Uh oh!

emilyalbini commented Apr 24, 2019

Uh oh!

bors commented Apr 24, 2019

Uh oh!

bors commented Apr 24, 2019

Uh oh!

fortanix-bot commented Apr 24, 2019

Uh oh!

bors commented Apr 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

emilyalbini commented Apr 23, 2019•
edited by Mark-Simulacrum
Loading

emilyalbini commented Apr 24, 2019•
edited
Loading