Uh oh!
There was an error while loading. Please reload this page.
coretest: Downgrade deny to warn - #60201
Merged
Merged
Conversation
rust-highfive
commented
Apr 23, 2019
Contributor
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
sanxiyn
commented
Apr 24, 2019
Contributor
This doesn't sound right. Isn't this what |
RalfJung
commented
Apr 24, 2019
MemberAuthor
Why not? I have set |
Centril
commented
Apr 28, 2019
Contributor
RalfJung
commented
May 11, 2019
MemberAuthor
Cc @rust-lang/libs -- needs someone to review. |
alexcrichton
commented
May 13, 2019
Member
@bors: r+ |
bors
commented
May 13, 2019
Collaborator
📌 Commit 4cb6d1c has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
May 13, 2019
coretest: Downgrade deny to warn The `deny` causes a build failure in https://github.com/RalfJung/miri-test-libstd. Since we use `-D warnings` for rustc builds, `warn` should be enough to lead to compile errors here, without impeding external builds.
bors added a commit
that referenced
this pull request
May 14, 2019
Rollup of 5 pull requests Successful merges: - #60176 (Explain error when yielding a reference to a local variable) - #60201 (coretest: Downgrade deny to warn) - #60562 (Add #[doc(hidden)] attribute on compiler generated module.) - #60710 (Use `delay_span_bug` for error cases when checking `AnonConst` parent) - #60770 (add impl_trait_in_bindings to INCOMPLETE_FEATURES) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
denycauses a build failure in https://github.com/RalfJung/miri-test-libstd. Since we use-D warningsfor rustc builds,warnshould be enough to lead to compile errors here, without impeding external builds.