Uh oh!
There was an error while loading. Please reload this page.
Derive Default instead of new in applicable lint - #60259
Conversation
rust-highfive
commented
Apr 25, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @zackmdavis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Centril
commented
Apr 25, 2019
This should also be applicable for |
Centril
commented
Apr 25, 2019
r? @Centril |
sd234678
commented
Apr 25, 2019
@Centril I can't see use of a |
Centril
commented
Apr 25, 2019
rust/src/librustc_lint/builtin.rs Lines 1288 to 1302 in 112f7e9 Line 97 in 112f7e9 |
sd234678
commented
Apr 25, 2019
@Centril Thanks, my mistake, I've found myself behind master. I'll rebase then update those too |
Centril
commented
Apr 25, 2019
r=me rollup with green travis. |
Centril
commented
Apr 25, 2019
@bors r+ rollup |
bors
commented
Apr 25, 2019
📌 Commit ef37f38 has been approved by |
…, r=Centril Derive Default instead of new in applicable lint Closesrust-lang#60181 As far as I can see, at least within the `src/librustc_lint` directory this is the only place this is applicable.
…, r=Centril Derive Default instead of new in applicable lint Closesrust-lang#60181 As far as I can see, at least within the `src/librustc_lint` directory this is the only place this is applicable.
…, r=Centril Derive Default instead of new in applicable lint Closesrust-lang#60181 As far as I can see, at least within the `src/librustc_lint` directory this is the only place this is applicable.
Rollup of 12 pull requests Successful merges: - #59734 (Prevent failure in case no space left on device in rustdoc) - #59940 (Set cfg(test) when rustdoc is running with --test option) - #60134 (Fix index-page generation) - #60165 (Add Pin::{into_inner,into_inner_unchecked}) - #60183 (Chalkify: Add builtin Copy/Clone) - #60225 (Introduce hir::ExprKind::Use and employ in for loop desugaring.) - #60247 (Implement Debug for Place using Place::iterate) - #60259 (Derive Default instead of new in applicable lint) - #60267 (Add feature-gate for f16c target feature) - #60284 (Do not allow const generics to depend on type parameters) - #60285 (Do not ICE when checking types against foreign fn) - #60289 (Make `-Z allow-features` work for stdlib features) Failed merges: r? @ghost
Closes#60181
As far as I can see, at least within the
src/librustc_lintdirectory this is the only place this is applicable.