Fact generation for liveness calculations in Polonius by amandasystems · Pull Request #60266 · rust-lang/rust

amandasystems · 2019-04-25T14:48:51Z

This PR tracks ongoing work to extend rustc with support for generating variable use, definition, and later also drop output for the Polonius solver, the whole of which is being tracked in Polonius Issue #104.

rust-highfive · 2019-04-25T14:48:55Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

amandasystems · 2019-04-25T14:50:35Z

r? @nikomatsakis

nikomatsakis

Looks basically correct to me!

nikomatsakis · 2019-04-30T20:44:04Z

Marking as "waiting on author", as we're waiting on @AlbinS to do some of the next steps.

nikomatsakis · 2019-05-06T16:22:58Z

seems correct

amandasystems · 2019-05-30T06:59:24Z

Now waiting for changes to land in Polonius: rust-lang/polonius#105

amandasystems · 2019-06-07T20:12:05Z

Hopefully not WIP anymore now that rust-lang/polonius#104 is merged!

bors · 2019-06-10T10:56:13Z

☔ The latest upstream changes (presumably #61506) made this pull request unmergeable. Please resolve the merge conflicts.

amandasystems · 2019-06-12T16:29:18Z

We have decided to do preliminary work on integrating initializiation tracking as well before merging this in order to get (hopefully) exactly the same output as rustc from Polonius, so back to WIP!

bors · 2019-06-14T19:09:35Z

☔ The latest upstream changes (presumably #61817) made this pull request unmergeable. Please resolve the merge conflicts.

amandasystems · 2019-07-09T10:34:09Z

This branch now has preliminary liveness calculations that uses a hack to extract initialisation status, which is needed for correct drop-liveness calculations. When we have initialisation tracking in Polonius that hack will go away, but for now and to the best of our knowledge these inputs compute exactly the same region liveness tuples as rustc previously generated, including for tricky edge cases™.

nikomatsakis · 2019-07-12T02:13:42Z

@bors r+

lqd · 2019-07-12T08:57:25Z

Just in case bors ignores commands on S-waiting-on-author:

@bors r=nikomatsakis

emilyalbini · 2019-07-12T09:25:40Z

@bors r=nikomatsakis

bors · 2019-07-12T09:25:41Z

📌 Commit 0612a666cd6529cd7a351a8f5d5697f45b2a126e has been approved by nikomatsakis

Notably contains an ugly hack to generate initialization information for variables that will go away when we have that functionality in Polonius.

lqd · 2019-07-13T07:39:33Z

Rebase is done

@bors r=nikomatsakis

bors · 2019-07-13T07:39:34Z

📌 Commit 9d3c59d has been approved by nikomatsakis

bors · 2019-07-13T10:15:46Z

⌛ Testing commit 9d3c59d with merge 6b468c6...

Fact generation for liveness calculations in Polonius This PR tracks ongoing work to extend `rustc` with support for generating variable use, definition, and later also drop output for the Polonius solver, the whole of which is being tracked in [Polonius Issue #104](rust-lang/polonius#104).

bors · 2019-07-13T13:44:35Z

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: nikomatsakis
Pushing 6b468c6 to master...

rust-highfive assigned eddyb Apr 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2019

rust-highfive assigned nikomatsakis and unassigned eddyb Apr 25, 2019

This comment has been minimized.
Sign in to view

nikomatsakis approved these changes Apr 25, 2019
View reviewed changes

nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2019

nikomatsakis reviewed May 6, 2019
View reviewed changes

Comment threadsrc/librustc_mir/borrow_check/nll/type_check/liveness/polonius.rs Outdated
nikomatsakisMay 6, 2019
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems correct

This comment has been minimized.
Sign in to view

amandasystems changed the title ~~[WIP] Fact generation for liveness calculations in Polonius~~Fact generation for liveness calculations in PoloniusJun 7, 2019

lqd added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2019

amandasystems changed the title ~~Fact generation for liveness calculations in Polonius~~[WIP] Fact generation for liveness calculations in PoloniusJun 12, 2019

lqd added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2019

amandasystems changed the title ~~[WIP] Fact generation for liveness calculations in Polonius~~Fact generation for liveness calculations in PoloniusJul 9, 2019

nikomatsakis approved these changes Jul 12, 2019
View reviewed changes

lqd removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 12, 2019

emilyalbini closed this Jul 12, 2019

emilyalbini reopened this Jul 12, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 12, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 12, 2019

Albin Stjerna added 3 commits July 12, 2019 22:41

Upgrade Polonius
e775bf3

polonius: add generation of liveneness-related facts
ac0a3d1
Notably contains an ugly hack to generate initialization information for variables that will go away when we have that functionality in Polonius.

rustfmt all the things!
9d3c59d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 13, 2019

bors merged commit 9d3c59d into rust-lang:masterJul 13, 2019

matthiaskrgr mentioned this pull request Apr 4, 2024
ICE: Failed to normalize Alias(Projection, AliasTy ..#113272
Closed

Uh oh!

Uh oh!

Conversation

amandasystems commented Apr 25, 2019

Uh oh!

rust-highfive commented Apr 25, 2019

Uh oh!

amandasystems commented Apr 25, 2019

Uh oh!

This comment has been minimized.

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Apr 30, 2019

Uh oh!

nikomatsakisMay 6, 2019

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

amandasystems commented May 30, 2019

Uh oh!

amandasystems commented Jun 7, 2019

Uh oh!

bors commented Jun 10, 2019

Uh oh!

amandasystems commented Jun 12, 2019

Uh oh!

bors commented Jun 14, 2019

Uh oh!

amandasystems commented Jul 9, 2019

Uh oh!

nikomatsakis commented Jul 12, 2019

Uh oh!

lqd commented Jul 12, 2019

Uh oh!

emilyalbini commented Jul 12, 2019

Uh oh!

bors commented Jul 12, 2019

Uh oh!

This comment has been minimized.

lqd commented Jul 13, 2019

Uh oh!

bors commented Jul 13, 2019

Uh oh!

bors commented Jul 13, 2019

Uh oh!

bors commented Jul 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants