Uh oh!
There was an error while loading. Please reload this page.
Cleanup the MIR visitor - #60276
Merged
Merged
Conversation
rust-highfive
commented
Apr 25, 2019
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
matthewjasperforce-pushed
the
cleanup-mir-visitor
branch
from
April 26, 2019 21:18
a5e3972 to
4e69d37Compareestebank
commented
Apr 29, 2019
Contributor
@bors r+ |
bors
commented
Apr 29, 2019
Collaborator
📌 Commit 4e69d37 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…r=estebank Cleanup the MIR visitor * Remove useless `BasicBlock` parameters on methods with `Location`s. * Prefer `visit_terminator_kind` to `visit_terminator`. * Remove `Region` from PlaceContexts. `visit_rvalue` should be used when the region is important. * Remove unused visitor methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasicBlockparameters on methods withLocations.visit_terminator_kindtovisit_terminator.Regionfrom PlaceContexts.visit_rvalueshould be used when the region is important.