Uh oh!
There was an error while loading. Please reload this page.
Elide unused import errors for failed use statements - #60295
Closed
estebank wants to merge 1 commit into
Closed
Conversation
rust-highfive
commented
Apr 26, 2019
Contributor
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
estebankforce-pushed
the
unused-imports-error
branch
2 times, most recently
from
April 26, 2019 18:15
e49854c to
274b3d2Compare
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
unused-imports-error
branch
from
April 26, 2019 18:50
274b3d2 to
f168d97Compareestebank
commented
Apr 26, 2019
ContributorAuthor
If we don't want to pay the price of iterating over all the spans, we can simply silence all unused import lints if any import errors have been found, but I slightly prefer this more targeted approach. |
petrochenkov
commented
Apr 28, 2019
Contributor
Unresolved imports are resolved to |
petrochenkov
commented
Apr 28, 2019
Contributor
Superseded by #60359 |
Centril added a commit
to Centril/rust
that referenced
this pull request
Apr 29, 2019
resolve: Consider erroneous imports used to avoid duplicate diagnostics Supersedes rust-lang#60295Fixesrust-lang#48244 r? @estebank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#48244