Skip to content

hir: remove LoweredNodeId - #60305

Merged
bors merged 1 commit into
rust-lang:masterfrom
ljedrz:remove_LoweredNodeId
Apr 29, 2019
Merged

hir: remove LoweredNodeId#60305
bors merged 1 commit into
rust-lang:masterfrom
ljedrz:remove_LoweredNodeId

Conversation

@ljedrz

@ljedrzljedrz commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

It seems that we no longer need it, because nowadays we just want the HirId most of the time.

@rust-highfive

rust-highfive commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2019
Centril
Centril reviewed Apr 26, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies generally in various places in the file.

Comment threadsrc/librustc/hir/lowering.rs Outdated
@ljedrz
ljedrzforce-pushed the remove_LoweredNodeId branch from b97eb16 to c95fd35CompareApril 26, 2019 12:47
Centril
Centril reviewed Apr 26, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more cases... more generally, search for let hir_id = self.lower_node_id(

Comment threadsrc/librustc/hir/lowering.rs Outdated
Comment threadsrc/librustc/hir/lowering.rs Outdated
Comment threadsrc/librustc/hir/lowering.rs Outdated
Comment threadsrc/librustc/hir/lowering.rs Outdated
Comment threadsrc/librustc/hir/lowering.rs Outdated
Comment threadsrc/librustc/hir/lowering.rs Outdated
Comment threadsrc/librustc/hir/lowering.rs Outdated
@ljedrz
ljedrzforce-pushed the remove_LoweredNodeId branch from c95fd35 to 83d6c40CompareApril 26, 2019 13:23
@ljedrz

ljedrz commented Apr 26, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril This time I think I even got some you haven't noticed yet 😉 .

@Centril

Centril commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

@ljedrz Yea; nice work :) -- I think you caught 'em all.

Zoxc
Zoxc reviewed Apr 28, 2019
View reviewed changes
Comment threadsrc/librustc/hir/lowering.rs Outdated
Zoxc
Zoxc reviewed Apr 28, 2019
View reviewed changes
Comment threadsrc/librustc/hir/lowering.rs Outdated
@ZoxcZoxc assigned Zoxc and unassigned eddybApr 28, 2019
@ljedrz
ljedrzforce-pushed the remove_LoweredNodeId branch from 83d6c40 to d536ec4CompareApril 29, 2019 10:13
@Zoxc

Zoxc commented Apr 29, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 29, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d536ec4 has been approved by Zoxc

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 29, 2019
@Centril
Rollup merge ofrust-lang#60305- ljedrz:remove_LoweredNodeId, r=Zoxc
67b7f57
hir: remove LoweredNodeId
It seems that we no longer need it, because nowadays we just want the `HirId` most of the time.
@CentrilCentril mentioned this pull request Apr 29, 2019
Merged
bors added a commit that referenced this pull request Apr 29, 2019
@bors
Auto merge of#60377- Centril:rollup-42fxe9u, r=Centril
00859e3
Rollup of 9 pull requests
Successful merges:
- #59946 (Fix equivalent string in escape_default docs)
- #60256 (Option::flatten)
- #60305 (hir: remove LoweredNodeId)
- #60334 (Stabilized vectored IO)
- #60353 (Add test not to forget resolved ICE)
- #60356 (Stabilize str::as_mut_ptr)
- #60358 (Clarify the short explanation of E0207)
- #60359 (resolve: Consider erroneous imports used to avoid duplicate diagnostics)
- #60360 (Add test case for labeled break in const assignment)
Failed merges:
r? @ghost
@bors

bors commented Apr 29, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #60377) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2019
@bors
bors merged commit d536ec4 into rust-lang:masterApr 29, 2019
@ljedrz
ljedrz deleted the remove_LoweredNodeId branch April 30, 2019 02:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@ZoxcZoxcZoxc left review comments
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ZoxcZoxc

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ljedrz@rust-highfive@Centril@Zoxc@bors@eddyb