Skip to content

Stabilize Option::xor - #60376

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:stabilize-option_xor
Jun 13, 2019
Merged

Stabilize Option::xor#60376
bors merged 1 commit into
rust-lang:masterfrom
tesuji:stabilize-option_xor

Conversation

@tesuji

@tesujitesuji commented Apr 29, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

FCP done in #50512 (comment) .

Closes#50512 .

@rust-highfive

rust-highfive commented Apr 29, 2019

Copy link
Copy Markdown
Contributor

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Apr 29, 2019

Copy link
Copy Markdown
Collaborator

Error: Label relnotes can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbotrustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 29, 2019
@jonas-schievinkjonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 29, 2019
@jonas-schievinkjonas-schievink added this to the 1.36 milestone Apr 29, 2019
@tesuji

tesuji commented Apr 29, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @Mark-Simulacrum

@Mark-Simulacrum

Mark-Simulacrum commented Apr 29, 2019

Copy link
Copy Markdown
Member

FCP completed but @Amanieu and @withoutboats expressed doubts so I'm going to r? @Amanieu for final approval.

@tesuji

tesuji commented May 9, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Are there any updates from libs team?

@tesuji

tesuji commented May 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi, is there any update yet?

@Centril

Centril commented May 18, 2019

Copy link
Copy Markdown
Contributor

Would love to see this stabilized. I do think it brings clarity and ergonomics to the "I have several incompatible options, select one of them but only if that's the only one given"-usecase. I've hit that before when working on proc macro implementations.

@taiki-e

taiki-e commented May 18, 2019

Copy link
Copy Markdown
Member

@Centril

I do think it brings clarity and ergonomics to the "I have several incompatible options, select one of them but only if that's the only one given"-usecase.

If I understand correctly, Option::xor can only be used if there are two options in this use-case.

@Centril

Centril commented May 18, 2019

Copy link
Copy Markdown
Contributor

If I understand correctly, Option::xor can only be used if there are two options in this use-case.

@taiki-e Yeah that's true; In my cases I only had two options.

@tesuji
tesujiforce-pushed the stabilize-option_xor branch from c72a5d4 to da56758CompareMay 27, 2019 09:08
@tesuji

tesuji commented May 27, 2019

Copy link
Copy Markdown
ContributorAuthor

@Amanieu Does the lib team have any updates?

@CentrilCentril modified the milestones: 1.36, 1.37May 27, 2019
@tesuji
tesujiforce-pushed the stabilize-option_xor branch from da56758 to 1fa50b3CompareJune 5, 2019 02:17
@tesuji

tesuji commented Jun 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Spamming ping @Amanieu .

@SimonSapin

SimonSapin commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

Per FCP:

@bors r+

@bors

bors commented Jun 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1fa50b3 has been approved by SimonSapin

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2019
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 12, 2019
@Centril

Centril commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
@Centril
Rollup merge ofrust-lang#60376- lzutao:stabilize-option_xor, r=Simo…
20858c4
…nSapin
Stabilize Option::xor
FCP done in rust-lang#50512 (comment) .
Closesrust-lang#50512 .
@CentrilCentril mentioned this pull request Jun 12, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
@Centril
Rollup merge ofrust-lang#60376- lzutao:stabilize-option_xor, r=Simo…
b35aeae
…nSapin
Stabilize Option::xor
FCP done in rust-lang#50512 (comment) .
Closesrust-lang#50512 .
@CentrilCentril mentioned this pull request Jun 12, 2019
Merged
bors added a commit that referenced this pull request Jun 13, 2019
@bors
Auto merge of#61789- Centril:rollup-hhyvopq, r=Centril
d8f50ab
Rollup of 9 pull requests
Successful merges:
- #60376 (Stabilize Option::xor)
- #61398 (Stabilize copy_within)
- #61629 (Hygienize macros in the standard library)
- #61675 (Include frame pointer for bare metal RISC-V targets)
- #61750 (Fix x.py install)
- #61761 (Add an alias for x86_64-sun-solaris target tuple)
- #61762 (rustbuild: fix libtest_stamp)
- #61763 (ci: fix ci stats upload condition)
- #61776 (Fix typos in error_codes)
Failed merges:
r? @ghost
@bors
bors merged commit 1fa50b3 into rust-lang:masterJun 13, 2019
@tesuji
tesuji deleted the stabilize-option_xor branch June 13, 2019 05:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AmanieuAmanieu

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.37

Development

Successfully merging this pull request may close these issues.

Tracking issue for Option::xor

11 participants

@tesuji@rust-highfive@rustbot@Mark-Simulacrum@Centril@taiki-e@SimonSapin@bors@Amanieu@aidanhs@jonas-schievink