Uh oh!
There was an error while loading. Please reload this page.
Warn about unsafe blocks in unsafe functions - #6038
Closed
alexcrichton wants to merge 3 commits into
Closed
Conversation
bors added a commit
that referenced
this pull request
Apr 24, 2013
Because unsafe functions are never warned about, then all `unsafe` blocks in unsafe functions should definitely be warned about (no need to be redundant). This fixes this case, adds tests, cleans up remaining cases, and then fixes a few other import warnings being spit out.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 24, 2020
Add `manual-strip` lint Add `manual-strip` lint. changelog: Add `manual-strip` lint
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
The proper fix I think is: * move rust-lang/rust library crates to a separate workspace * when packaging rust-src component, vendor sources of external deps
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
6294: Add a hacky remidy for rust-lang#6038 r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because unsafe functions are never warned about, then all
unsafeblocks in unsafe functions should definitely be warned about (no need to be redundant). This fixes this case, adds tests, cleans up remaining cases, and then fixes a few other import warnings being spit out.