libprofiler_builtins: Set compilation flags more correctly for C code. by michaelwoerister · Pull Request #60402 · rust-lang/rust

michaelwoerister · 2019-04-30T08:51:40Z

In particular, set COMPILER_RT_HAS_FCNTL_LCK and COMPILER_RT_HAS_ATOMICS as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries.

The build script is using a heuristic here that hopefully is sufficient for the time being.

r? @alexcrichton

Fixes#59531.

alexcrichton · 2019-04-30T14:15:13Z

@bors: r+

bors · 2019-04-30T14:15:16Z

📌 Commit d52fde2 has been approved by alexcrichton

@alexcrichton

…-build, r=alexcrichton libprofiler_builtins: Set compilation flags more correctly for C code. In particular, set `COMPILER_RT_HAS_FCNTL_LCK` and `COMPILER_RT_HAS_ATOMICS` as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries. The build script is using a heuristic here that hopefully is sufficient for the time being. r? @alexcrichtonFixesrust-lang#59531.

tesuji · 2019-04-30T20:02:51Z

Failed in #60420 (comment) .
@rustbot modify labels to -S-waiting-on-bors and +S-waiting-on-author

Centril · 2019-05-01T04:23:19Z

@bors r- ^

michaelwoerister · 2019-05-02T09:52:27Z

Typo fixed.

@bors r=alexcrichton

bors · 2019-05-02T09:52:28Z

📌 Commit d4dfbeb has been approved by alexcrichton

@alexcrichton

…-build, r=alexcrichton libprofiler_builtins: Set compilation flags more correctly for C code. In particular, set `COMPILER_RT_HAS_FCNTL_LCK` and `COMPILER_RT_HAS_ATOMICS` as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries. The build script is using a heuristic here that hopefully is sufficient for the time being. r? @alexcrichtonFixesrust-lang#59531.

bors · 2019-05-04T18:28:21Z

⌛ Testing commit d4dfbeb with merge c3b08da044476a942cf78b3b4fc67d943a5890be...

bors · 2019-05-04T19:49:01Z

💔 Test failed - status-appveyor

michaelwoerister · 2019-05-07T11:16:35Z

I was able reproduce this locally. It seems that Clang 7 can't handle some of the C instrinsics for Arm64 Windows yet. Switching to Clang 8 fixes the problem.

@rust-lang/infra, how would I update the clang version defined here?

rust/appveyor.yml

Lines 152 to 164 in 55c48b4

# If we're compiling for MSVC then we, like most other distribution builders,
# switch to clang as the compiler. This'll allow us eventually to enable LTO
# amongst LLVM and rustc. Note that we only do this on MSVC as I don't think
# clang has an output mode compatible with MinGW that we need. If it does we
# should switch to clang for MinGW as well!
#
# Note that the LLVM installer is an NSIS installer
#
# Original downloaded here came from
# http://releases.llvm.org/7.0.0/LLVM-7.0.0-win64.exe
 - if NOT defined MINGW_URL appveyor-retry appveyor DownloadFile https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rust-ci-mirror/LLVM-7.0.0-win64.exe
 - if NOT defined MINGW_URL .\LLVM-7.0.0-win64.exe /S /NCRC /D=C:\clang-rust
 - if NOT defined MINGW_URL set RUST_CONFIGURE_ARGS=%RUST_CONFIGURE_ARGS% --set llvm.clang-cl=C:\clang-rust\bin\clang-cl.exe

alexcrichton · 2019-05-08T14:13:49Z

Ok I've uploaded the 8.0.0 binary to our CI bucket, if you update s/7/8/g here I think it should work

michaelwoerister · 2019-05-08T15:01:30Z

❤️

In particular, set COMPILER_RT_HAS_FCNTL_LCK and COMPILER_RT_HAS_ATOMICS as appropriate.

michaelwoerister · 2019-05-08T15:06:52Z

Clang version updated.

@bors r=alexcrichton

bors · 2019-05-08T15:06:53Z

📌 Commit 0ffc573 has been approved by alexcrichton

bors · 2019-05-08T18:30:21Z

⌛ Testing commit 0ffc573 with merge 9bee31424656ffbdc627226a394857a8aeb80ff9...

Centril · 2019-05-08T18:32:41Z

@bors retry

bors · 2019-05-08T18:38:20Z

⌛ Testing commit 0ffc573 with merge 3f5152e...

@alexcrichton

…lexcrichton libprofiler_builtins: Set compilation flags more correctly for C code. In particular, set `COMPILER_RT_HAS_FCNTL_LCK` and `COMPILER_RT_HAS_ATOMICS` as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries. The build script is using a heuristic here that hopefully is sufficient for the time being. r? @alexcrichtonFixes#59531.

bors · 2019-05-08T22:24:43Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 3f5152e to master...

rust-highfive · 2019-05-08T22:26:51Z

📣 Toolstate changed by #60402!

Tested on commit 3f5152e.
Direct link to PR: #60402

💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).

@Xanewok

Tested on commit rust-lang/rust@3f5152e. Direct link to PR: <rust-lang/rust#60402> 💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra). 🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).

michaelwoerister · 2019-05-09T09:37:08Z

It landed :) Thanks for your help, @alexcrichton!

I'm wondering how RLS could be affected by these changes...

kennytm · 2019-05-09T10:52:03Z

There's a spurious test in RLS 😓

michaelwoerister · 2019-05-09T10:58:57Z

Ah, OK. Thanks for the info, @kennytm!

rust-highfive assigned alexcrichton Apr 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2019

Centril mentioned this pull request Apr 30, 2019
Rollup of 7 pull requests #60420
Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2019

michaelwoerister force-pushed the update-profiler-rt-build branch from d52fde2 to d4dfbebCompare May 2, 2019 09:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2019

michaelwoerister mentioned this pull request May 2, 2019
Tracking Issue for stabilizing Profile-Guided Optimization support #59913
Closed
16 tasks

kennytm mentioned this pull request May 2, 2019
Rollup of 7 pull requests #60472
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2019

michaelwoerister added 2 commits May 8, 2019 17:02

libprofiler_builtins: Set compilation flags more correctly for C code.
e65ef96
In particular, set COMPILER_RT_HAS_FCNTL_LCK and COMPILER_RT_HAS_ATOMICS as appropriate.

AppVeyor: Update clang-cl from 7.0.0 to 8.0.0
0ffc573

michaelwoerister force-pushed the update-profiler-rt-build branch from d4dfbeb to 0ffc573Compare May 8, 2019 15:05

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2019

bors merged commit 0ffc573 into rust-lang:masterMay 8, 2019

Uh oh!

Uh oh!

Conversation

michaelwoerister commented Apr 30, 2019

Uh oh!

alexcrichton commented Apr 30, 2019

Uh oh!

bors commented Apr 30, 2019

Uh oh!

tesuji commented Apr 30, 2019

Uh oh!

Centril commented May 1, 2019

Uh oh!

michaelwoerister commented May 2, 2019

Uh oh!

bors commented May 2, 2019

Uh oh!

bors commented May 4, 2019

Uh oh!

bors commented May 4, 2019

Uh oh!

michaelwoerister commented May 7, 2019

Uh oh!

alexcrichton commented May 8, 2019

Uh oh!

michaelwoerister commented May 8, 2019

Uh oh!

michaelwoerister commented May 8, 2019

Uh oh!

bors commented May 8, 2019

Uh oh!

bors commented May 8, 2019

Uh oh!

Centril commented May 8, 2019

Uh oh!

bors commented May 8, 2019

Uh oh!

bors commented May 8, 2019

Uh oh!

rust-highfive commented May 8, 2019

Uh oh!

michaelwoerister commented May 9, 2019

Uh oh!

kennytm commented May 9, 2019

Uh oh!

michaelwoerister commented May 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants