Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #60416
Merged
Merged
Conversation
Previously, we checked if the target of a projection type was itself an
inference variable. However, for Rustdoc rendering purposes, there's no
distinction between an inference variable ('_') and a type containing
one (e.g. (MyStruct<u8, _>)) - we don't want to render either of them.
Fixesrust-lang#60269
Due to the complexity of the original bug, which spans three different
crates (hyper, tower-hyper, and tower), I have been unable to create a
minimized reproduction for the issue.This reverts commit 6bafc58.
Don't try to render auto-trait bounds with any inference variables
Previously, we checked if the target of a projection type was itself an
inference variable. However, for Rustdoc rendering purposes, there's no
distinction between an inference variable ('_') and a type containing
one (e.g. (MyStruct<u8, _>)) - we don't want to render either of them.
Fixesrust-lang#60269
Due to the complexity of the original bug, which spans three different
crates (hyper, tower-hyper, and tower), I have been unable to create a
minimized reproduction for the issue.…cepted, r=oli-obk Cleanup declare_features! for 'accepted' with a uniform style + sort them r? @oli-obk cc rust-lang#60362 cc rust-lang#60361
…tive, r=oli-obk Cleanup 'active' declare_features! with uniform style + sorting. r? @oli-obk (added the FIXME you wanted) cc rust-lang#60354 cc rust-lang#60361
…llaumeGomez Revert "Update Source Code Pro fonts to version 2.030" Temporary fix for rust-lang#60365rust-lang#60146 updated all fonts (not just the fonts that were buggy), however it looks like the new Source Code Pro is buggy. We should test this out of tree: `cargo doc` on anything, replace the font in `target/doc`, and use `python -m SimpleHTTPServer` to see what's going on. Till we figure that out, I'll just back this out. r? @GuillaumeGomez This reverts commit 6bafc58.
…ewjasper Remove functions to simplify handling of feature(bind_by_move_pattern_guards) Fixesrust-lang#59192 r? @matthewjasper
Add missing f16c_target_feature check to typeck collect
Centril
commented
Apr 30, 2019
ContributorAuthor
@bors r+ p=7 |
bors
commented
Apr 30, 2019
Collaborator
📌 Commit 71a1b80 has been approved by |
bors
commented
Apr 30, 2019
Collaborator
bors added a commit
that referenced
this pull request
Apr 30, 2019
Rollup of 7 pull requests Successful merges: - #60344 (Don't try to render auto-trait bounds with any inference variables) - #60354 (Cleanup declare_features! for 'accepted' with a uniform style + sort them) - #60362 (Cleanup 'active' declare_features! with uniform style + sorting.) - #60382 (Revert "Update Source Code Pro fonts to version 2.030") - #60399 (Update clippy) - #60400 (Remove functions to simplify handling of feature(bind_by_move_pattern_guards)) - #60408 (Add missing f16c_target_feature check to typeck collect) Failed merges: r? @ghost
bors
commented
Apr 30, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
commented
Apr 30, 2019
Contributor
📣 Toolstate changed by #60416! Tested on commit 5b7baa5. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 30, 2019
Tested on commit rust-lang/rust@5b7baa5. Direct link to PR: <rust-lang/rust#60416> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra). 🎉 rls on windows: build-fail → test-fail (cc @Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost