Uh oh!
There was an error while loading. Please reload this page.
Refactor eval_body_using_ecx so that it doesn't need to query for MIR - #60428
Merged
Conversation
oli-obk
reviewed
May 1, 2019
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
reviewed
May 1, 2019
Uh oh!
There was an error while loading. Please reload this page.
wesleywiserforce-pushed
the
refactor_const_eval
branch
from
May 1, 2019 12:12
1c2b5d2 to
04609a5Comparewesleywiser
commented
May 1, 2019
MemberAuthor
@oli-obk Done |
oli-obk
commented
May 1, 2019
Contributor
Huh. Doesn't this also require changes at the call site to |
wesleywiserforce-pushed
the
refactor_const_eval
branch
from
May 1, 2019 12:27
04609a5 to
eadf48eComparewesleywiser
commented
May 1, 2019
MemberAuthor
Ah yes, I accidentally put that in a later commit. |
oli-obk
commented
May 1, 2019
Contributor
@bors r+ |
bors
commented
May 1, 2019
Collaborator
📌 Commit eadf48e has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
May 1, 2019
…oli-obk Refactor `eval_body_using_ecx` so that it doesn't need to query for MIR This is the first step toward removing the `mir` field of `ConstPropagator` which will eventually allow us to actually const propagate in MIR. r? @oli-obk
bors added a commit
that referenced
this pull request
May 2, 2019
Rollup of 7 pull requests Successful merges: - #59634 (Added an explanation for the E0704 error.) - #60348 (move some functions from parser.rs to diagostics.rs) - #60385 (Emit metadata files earlier) - #60428 (Refactor `eval_body_using_ecx` so that it doesn't need to query for MIR) - #60437 (Ensure that drop order of `async fn` matches `fn` and that users cannot refer to generated arguments.) - #60439 (doc: Warn about possible zombie apocalypse) - #60452 (Remove Context and ContextKind) Failed merges: r? @ghost
Centril added a commit
to Centril/rust
that referenced
this pull request
May 2, 2019
… r=oli-obk Const prop refactoring This is rebased on top of rust-lang#60428 so only the top commit is new. This is the refactoring to remove the `mir` field from `ConstPropagator` which is necessary before we can begin to actually propagate constants. r? @oli-obk
Centril added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
… r=oli-obk Const prop refactoring This is rebased on top of rust-lang#60428 so only the top commit is new. This is the refactoring to remove the `mir` field from `ConstPropagator` which is necessary before we can begin to actually propagate constants. r? @oli-obk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step toward removing the
mirfield ofConstPropagatorwhich will eventually allow us to actually const propagate in MIR.r? @oli-obk