Skip to content

Updated RELEASES.md for 1.35.0 - #60546

Closed
XAMPPRocky wants to merge 6 commits into
rust-lang:masterfrom
XAMPPRocky:master
Closed

Updated RELEASES.md for 1.35.0#60546
XAMPPRocky wants to merge 6 commits into
rust-lang:masterfrom
XAMPPRocky:master

Conversation

@XAMPPRocky

@XAMPPRockyXAMPPRocky commented May 4, 2019

Copy link
Copy Markdown
Contributor

Rendered

r? @Mark-Simulacrum

cc @rust-lang/release @steveklabnik

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2019
@matthewjaspermatthewjasper added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 4, 2019
Centril
Centril suggested changes May 4, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
@Centril@XAMPPRocky
Update RELEASES.md
79cf6c0
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Centril
Centril reviewed May 4, 2019
View reviewed changes
Comment threadRELEASES.md
jonas-schievink
jonas-schievink suggested changes May 4, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
taiki-e
taiki-e reviewed May 4, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
@jonas-schievinkjonas-schievink added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label May 4, 2019
@emilyalbini

emilyalbini commented May 4, 2019

Copy link
Copy Markdown
Member

@rustbot modify labels: beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 4, 2019
sfackler
sfackler reviewed May 4, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
jonas-schievinkand others added 4 commits May 5, 2019 10:10
@jonas-schievink@XAMPPRocky
Update RELEASES.md
6b7ad03
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
@taiki-e@XAMPPRocky
Update RELEASES.md
869c5f7
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
@sfackler@XAMPPRocky
Update RELEASES.md
c058066
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
@XAMPPRocky
Update RELEASES.md
5d41e7c
@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2019

Copy link
Copy Markdown
Member

This is looking good to me; let's aim to get it landed this week so we're ready for release next week.

jonas-schievink
jonas-schievink reviewed May 14, 2019
View reviewed changes
Comment threadRELEASES.md
@bors

bors commented May 14, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #60787) made this pull request unmergeable. Please resolve the merge conflicts.

emilyalbini
emilyalbini requested changes May 14, 2019
View reviewed changes

@emilyalbiniemilyalbini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on master and add the CVE number to the 1.34.2 release?

@jonas-schievink

jonas-schievink commented May 14, 2019

Copy link
Copy Markdown
Contributor

Closing in favor of #60837 (since I can't push to this fork)

@emilyalbiniemilyalbini removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilyalbiniemilyalbiniemilyalbini requested changes
@CentrilCentrilAwaiting requested review from Centril
+4 more reviewers
@sfacklersfacklersfackler left review comments
@jonas-schievinkjonas-schievinkjonas-schievink requested changes
@taiki-etaiki-etaiki-e left review comments
@BatmanAoDBatmanAoDBatmanAoD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@XAMPPRocky@emilyalbini@Mark-Simulacrum@bors@jonas-schievink@Centril@sfackler@BatmanAoD@taiki-e@rust-highfive@matthewjasper@rustbot