Fix a couple of FIXMEs in ext::tt::transcribe by mark-i-m · Pull Request #60620 · rust-lang/rust

mark-i-m · 2019-05-07T23:08:51Z

Blocked on #60618

A crater run would be nice to make sure my understanding is correct. A quick google search seems to indicate these are extremely rare errors if they are possible (which I don't believe they are).

r? @petrochenkov

cc #2887 (there is only one FIXME left and it is hygiene-related)

rust-highfive · 2019-05-07T23:40:02Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:22c62a1a:start=1557270611248650305,finish=1557270699296880999,duration=88048230694
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:28:03] Compiling core v0.0.0 (/checkout/src/libcore)
[00:28:03] Compiling libc v0.2.54
[00:28:03] Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:28:04] Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:28:04] thread 'rustc' panicked at 'assertion failed: src.len() > 0', src/libsyntax/ext/tt/transcribe.rs:74:5
[00:28:04] [00:28:04] error: internal compiler error: unexpected panic
[00:28:04] [00:28:04] note: the compiler unexpectedly panicked. this is a bug.
[00:28:04] note: the compiler unexpectedly panicked. this is a bug.
[00:28:04] [00:28:04] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:28:04] [00:28:04] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[00:28:04] [00:28:04] note: compiler flags: -Z external-macro-backtrace -Z unstable-options -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C codegen-units=1 -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:28:04] note: some of the compiler flags provided by cargo are hidden
[00:28:04] [00:28:04] error: Could not compile `core`.
[00:28:04] warning: build failed, waiting for other jobs to finish...

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

petrochenkov · 2019-05-09T19:03:34Z

@bors try (for crater)

bors · 2019-05-09T19:03:46Z

⌛ Trying commit 59019a5cfc94833d32354c0fd83385c67da1b78c with merge a7cff45e655f886da150e206c7acbe984df4ab71...

bors · 2019-05-09T21:39:14Z

☀️ Try build successful - checks-travis
Build commit: a7cff45e655f886da150e206c7acbe984df4ab71

petrochenkov · 2019-05-09T21:46:03Z

@craterbot run mode=check-only

craterbot · 2019-05-09T21:46:05Z

👌 Experiment pr-60620 created and queued.
🤖 Automatically detected try build a7cff45e655f886da150e206c7acbe984df4ab71
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-09T21:46:07Z

🚧 Experiment pr-60620 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-09T21:46:09Z

🚨 Experiment pr-60620 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

emilyalbini · 2019-05-09T21:52:09Z

@craterbot retry

Wut docker died.

craterbot · 2019-05-09T21:52:11Z

🛠️ Experiment pr-60620 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-09T21:52:15Z

🚧 Experiment pr-60620 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-10T02:24:52Z

🚨 Experiment pr-60620 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

mark-i-m · 2019-05-10T02:58:15Z

Completed jobs: 98346 / 98348

😢

emilyalbini · 2019-05-10T07:01:32Z

What is happening with this agent :/

@craterbot retry

craterbot · 2019-05-10T07:01:33Z

🛠️ Experiment pr-60620 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-10T07:01:34Z

🚧 Experiment pr-60620 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-10T08:00:43Z

🎉 Experiment pr-60620 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

emilyalbini · 2019-05-10T08:23:20Z

Whelp that run completly broke (no successful tests...).

@craterbot run mode=check-only assign=agent:aws-2

craterbot · 2019-05-10T08:23:22Z

👌 Experiment pr-60620-1 created and queued.
🤖 Automatically detected try build a7cff45e655f886da150e206c7acbe984df4ab71
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-05-10T13:54:57Z

🎉 Experiment pr-60620-1 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2019-05-10T14:29:48Z

Unless this PR is useful as a testing ground for crater, I'd suggest to just land it and revert with tests if it turns out that the code hitting these ICEs is possible, there's plenty of time to do that (there are also regular beta crater runs).

mark-i-m · 2019-05-10T15:10:02Z

@petrochenkov Sure, it looks like there were no regressions, which is expected. I can rebase the PR and it will be ready to be merged. @pietroalbini do you want me to wait?

emilyalbini · 2019-05-10T15:14:48Z

I haven't had time to investigate this yet, but I don't need this PR to be open to be able to do that (the try builds are already uploaded).

mark-i-m · 2019-05-10T15:19:52Z

@pietroalbini Ok, thanks :) @petrochenkov I rebased.

petrochenkov · 2019-05-10T15:24:35Z

it looks like there were no regressions

That's because crater is broken.

@bors r+ rollup

bors · 2019-05-10T15:24:36Z

📌 Commit 5b6bda3 has been approved by petrochenkov

emilyalbini · 2019-05-10T15:38:03Z

@mark-i-m @petrochenkov I found the crater bug and I should have a patch deployed in max a few hours. Do you want to r-?

mark-i-m · 2019-05-10T15:43:40Z

@petrochenkov Ah I see. I'm fine with waiting for the crater run if you want... This PR is not super-high priority. These FIXMEs have been around for ~7 years IIUC...

emilyalbini · 2019-05-10T15:51:03Z

@bors r-

emilyalbini · 2019-05-10T16:31:07Z

@bors r=petrochenkov rollup

This will likely require more time to fully investigate since Cargo changed how its internal locking works, conflicting with Crater wanting to make as much stuff as possible read-only.

bors · 2019-05-10T16:31:10Z

📌 Commit 5b6bda3 has been approved by petrochenkov

@petrochenkov

Fix a couple of FIXMEs in ext::tt::transcribe _Blocked on #60618_ A crater run would be nice to make sure my understanding is correct. A quick google search seems to indicate these are extremely rare errors if they are possible (which I don't believe they are). r? @petrochenkov cc rust-lang#2887 (there is only one FIXME left and it is hygiene-related)

@ghost

Rollup of 6 pull requests Successful merges: - #60529 (RFC 2008: Uninhabitedness fixes for enum variants and tests) - #60620 (Fix a couple of FIXMEs in ext::tt::transcribe) - #60659 (Tweak `Symbol` and `InternedString`) - #60692 (Extend #60676 test for nested mut patterns.) - #60697 (add regression test for #60629) - #60701 (Update mailmap for mati865) Failed merges: r? @ghost

rust-highfive assigned petrochenkov May 7, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2019

mark-i-m mentioned this pull request May 7, 2019
Use proper spans in ext::tt::transcribe #2887
Closed

mark-i-m force-pushed the transcribe-2 branch from 878b439 to 59019a5Compare May 8, 2019 18:34

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2019

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 10, 2019

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2019

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 10, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2019

turn a couple of fixmes into span_bugs
5b6bda3

mark-i-m force-pushed the transcribe-2 branch from 59019a5 to 5b6bda3Compare May 10, 2019 15:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2019

Centril mentioned this pull request May 10, 2019
Rollup of 6 pull requests #60708
Merged

bors merged commit 5b6bda3 into rust-lang:masterMay 10, 2019

oli-obk mentioned this pull request May 22, 2019
Inconsistent macro repeat operator leads to panic on nightly #61033
Closed

mark-i-m deleted the transcribe-2 branch May 25, 2019 02:15

Uh oh!

Uh oh!

Conversation

mark-i-m commented May 7, 2019

Uh oh!

rust-highfive commented May 7, 2019

Uh oh!

petrochenkov commented May 9, 2019

Uh oh!

bors commented May 9, 2019

Uh oh!

bors commented May 9, 2019

Uh oh!

petrochenkov commented May 9, 2019

Uh oh!

craterbot commented May 9, 2019

Uh oh!

craterbot commented May 9, 2019

Uh oh!

craterbot commented May 9, 2019

Uh oh!

emilyalbini commented May 9, 2019

Uh oh!

craterbot commented May 9, 2019

Uh oh!

craterbot commented May 9, 2019

Uh oh!

craterbot commented May 10, 2019

Uh oh!

mark-i-m commented May 10, 2019

Uh oh!

emilyalbini commented May 10, 2019

Uh oh!

craterbot commented May 10, 2019

Uh oh!

craterbot commented May 10, 2019

Uh oh!

craterbot commented May 10, 2019

Uh oh!

emilyalbini commented May 10, 2019

Uh oh!

craterbot commented May 10, 2019

Uh oh!

craterbot commented May 10, 2019

Uh oh!

petrochenkov commented May 10, 2019

Uh oh!

mark-i-m commented May 10, 2019

Uh oh!

emilyalbini commented May 10, 2019

Uh oh!

mark-i-m commented May 10, 2019

Uh oh!

petrochenkov commented May 10, 2019

Uh oh!

bors commented May 10, 2019

Uh oh!

emilyalbini commented May 10, 2019

Uh oh!

mark-i-m commented May 10, 2019

Uh oh!

emilyalbini commented May 10, 2019

Uh oh!

emilyalbini commented May 10, 2019

Uh oh!

bors commented May 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants