Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #60672
Merged
Merged
Conversation
This is similar to `NonNull::cast`. Compared to the `as` operator (which has a wide range of meanings depending on the input and output types), a call to this method: * Can only go from a raw pointer to a raw pointer * Cannot change the pointer’s `const`ness … even when the pointed types are inferred based on context.
(Partially) brings back rust-lang#33921
Add a `cast` method to raw pointers. This is similar to `NonNull::cast`. Compared to the `as` operator (which has a wide range of meanings depending on the input and output types), a call to this method: * Can only go from a raw pointer to a raw pointer * Cannot change the pointer’s `const`ness … even when the pointed types are inferred based on context.
pin: make the to-module link more visible Cc @gnzlbg
…ister cleanup: Remove `DefIndexAddressSpace` The scheme with two address spaces for `DefIndex` was needed in the past, but apparently not needed anymore (after removing `DefId`s from locals and `HirId`-ification).
…lice, r=sfackler Inline some Cursor calls for slices (Partially) brings back rust-lang#33921 I've noticed in some serialization code I was writing that writes to slices produce much, much, worse code than you'd expect even with optimizations turned on. For example, you'd expect something like this to be zero cost: ``` use std::io::{self, Cursor, Write}; pub fn serialize((a, b): (u64, u64)) -> [u8;8+8] { let mut r = [0u8;16]; { let mut w = Cursor::new(&mut r[..]); w.write(&a.to_le_bytes()).unwrap(); w.write(&b.to_le_bytes()).unwrap(); } r } ``` ...but it compiles down to [dozens of instructions](https://rust.godbolt.org/z/bdwDzb) because the `slice_write()` calls aren't inlined, which in turn means `unwrap()` can't be optimized away, and so on. To be clear, this pull-req isn't sufficient by itself: if we want to go down that path we also need to add `#[inline]`'s to the default implementations for functions like `write_all()` in the `Write` trait and so on, or implement them separately in the `Cursor` impls. But I figured I'd start a conversation about what tradeoffs we're expecting here.
…apin Stabilize and re-export core::array in std Fixesrust-lang#60014
Centril
commented
May 9, 2019
ContributorAuthor
@bors r+ p=5 rollup=never |
bors
commented
May 9, 2019
Collaborator
📌 Commit e40f9a6 has been approved by |
bors
commented
May 9, 2019
Collaborator
bors added a commit
that referenced
this pull request
May 9, 2019
Rollup of 5 pull requests Successful merges: - #60601 (Add a `cast` method to raw pointers.) - #60638 (pin: make the to-module link more visible) - #60647 (cleanup: Remove `DefIndexAddressSpace`) - #60656 (Inline some Cursor calls for slices) - #60657 (Stabilize and re-export core::array in std) Failed merges: r? @ghost
fortanix-bot
commented
May 9, 2019
Contributor
Due to #60657, looks like main CI is going to fail as well. |
jethrogb
commented
May 9, 2019
Contributor
Except dist-various-2 just passed...? |
jethrogb
commented
May 9, 2019
Contributor
Oh the use is only in |
bors
commented
May 9, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
commented
May 9, 2019
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 9, 2019
Tested on commit rust-lang/rust@a784a80. Direct link to PR: <rust-lang/rust#60672> 💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
Centril
commented
May 9, 2019
ContributorAuthor
Beta accepted specifically 028e78d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pietroalbini Remember to look at #60672 (comment).
Successful merges:
castmethod to raw pointers. #60601 (Add acastmethod to raw pointers.)DefIndexAddressSpace#60647 (cleanup: RemoveDefIndexAddressSpace)Failed merges:
r? @ghost