Skip to content

Remove unnecessary unwraps - #60720

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:no-ice-thanks
May 12, 2019
Merged

Remove unnecessary unwraps#60720
bors merged 1 commit into
rust-lang:masterfrom
estebank:no-ice-thanks

Conversation

@estebank

@estebankestebank commented May 10, 2019

Copy link
Copy Markdown
Contributor

Fix#60713.

@rust-highfive

rust-highfive commented May 10, 2019

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2019
estebank
estebank commented May 10, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/method/suggest.rs Outdated

@estebankestebankMay 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this change was needed, but avoiding the other unwraps is worthwhile.

@estebank

estebank commented May 10, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @zackmdavis

@rust-highfive

This comment has been minimized.

Sign in to view
@zackmdavis

zackmdavis commented May 11, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 11, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c158a0f has been approved by zackmdavis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2019
@jethrogb

jethrogb commented May 11, 2019

Copy link
Copy Markdown
Contributor

Needs test?

@zackmdavis

zackmdavis commented May 11, 2019

Copy link
Copy Markdown
Contributor

@jethrogb good question! Unless someone can further minimize your motivating example to not need a dependency (so, no juniper_codegen), I'm inclined to just trust @estebank on this one?

Centril added a commit to Centril/rust that referenced this pull request May 11, 2019
@Centril
Rollup merge ofrust-lang#60720- estebank:no-ice-thanks, r=zackmdavis
5da009e
Remove unnecessary unwraps
Fixrust-lang#60713.
@CentrilCentril mentioned this pull request May 11, 2019
Merged
bors added a commit that referenced this pull request May 11, 2019
@bors
Auto merge of#60748- Centril:rollup-rr63jqo, r=Centril
d28e948
Rollup of 4 pull requests
Successful merges:
- #60720 (Remove unnecessary unwraps)
- #60727 (add comment to `Rc`/`Arc`'s `Eq` specialization)
- #60733 (Cleanup the .await HIR lowering with .stmt(..).)
- #60741 (Remove redundant "let mut" in write_graph_label)
Failed merges:
r? @ghost
@estebank

estebank commented May 11, 2019

Copy link
Copy Markdown
ContributorAuthor

The ideal thing would be to add a test but because it required two crates to repro writing it would have taken me a hit longer. Having said that the change should be good as it is, but thanks for keeping your eyes peeled @jethrogb and thanks @zackmdavid for the vote of confidence ^_^

@bors
bors merged commit c158a0f into rust-lang:masterMay 12, 2019
@estebank
estebank deleted the no-ice-thanks branch November 9, 2023 05:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zackmdaviszackmdavis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE in rustc_typeck::check::method::suggest::<impl rustc_typeck::check::FnCtxt>::report_method_error

6 participants

@estebank@rust-highfive@zackmdavis@bors@jethrogb@pnkfelix