Skip to content

Fix minor typos for ItemLocalId - #60752

Merged
bors merged 1 commit into
rust-lang:masterfrom
shiatsumat:minor-typos-hir
May 12, 2019
Merged

Fix minor typos for ItemLocalId#60752
bors merged 1 commit into
rust-lang:masterfrom
shiatsumat:minor-typos-hir

Conversation

@shiatsumat

@shiatsumatshiatsumat commented May 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
  • added comma after 'that is'
  • "can be implement" -> "can be implemented"

@shiatsumat
Fix minor typos for ItemLocalId
0fc2cfb
* added comma before 'that is'
* "can be implement" -> "can be implemented"
@rust-highfive

rust-highfive commented May 12, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2019
@wesleywiser

wesleywiser commented May 12, 2019

Copy link
Copy Markdown
Member

Thanks!

r? @wesleywiser

@bors r+

@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2019
@wesleywiser

wesleywiser commented May 12, 2019

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

This comment has been minimized.

Sign in to view
@bors

bors commented May 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 0fc2cfb has been approved by wesleywiser

Centril added a commit to Centril/rust that referenced this pull request May 12, 2019
@Centril
Rollup merge ofrust-lang#60752- shiatsumat:minor-typos-hir, r=wesle…
b381e52
…ywiser
Fix minor typos for ItemLocalId
* added comma after 'that is'
* "can be implement" -> "can be implemented"
@CentrilCentril mentioned this pull request May 12, 2019
Merged
bors added a commit that referenced this pull request May 12, 2019
@bors
Auto merge of#60767- Centril:rollup-4cbsb73, r=Centril
4443957
Rollup of 4 pull requests
Successful merges:
- #60694 (Fix HIR printing of existential type #60662)
- #60750 (syntax: Remove some legacy nonterminal tokens)
- #60751 (Assorted cleanup in parser & AST validation)
- #60752 (Fix minor typos for ItemLocalId)
Failed merges:
r? @ghost
@bors
bors merged commit 0fc2cfb into rust-lang:masterMay 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@wesleywiserwesleywiser

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shiatsumat@rust-highfive@wesleywiser@bors@michaelwoerister