Always try to project predicates when finding auto traits in rustdoc

[Aaron1011]

Fixes#60726

Previous, AutoTraitFinder would only try to project predicates when the
predicate type contained an inference variable. When finding auto
traits, we only project to try to unify inference variables - we don't
otherwise learn any new information about the required bounds.

However, this lead to failing to properly generate a negative auto trait
impl (indicating that a type never implements a certain auto trait) in
the following unusual scenario:

In almost all cases, a type has an (implicit) negative impl of an auto
trait due some other type having an explicit negative impl of that
auto trait. For example:

struct MyType {
field: *const T
}

has an implicit 'impl !Send for MyType', due to the explicit
negative impl (in libcore) 'impl<T: ?Sized> !Send for *const T'.

However, as exposed by the 'abi_stable' crate, this isn't always the
case. This minimzed example shows how a type can never implement
'Send', due to a projection error:

pub struct True;
pub struct False;
pub trait MyTrait {
type Project;
}
pub struct MyStruct<T> {
field: T
}
impl MyTrait for u8 {
type Project = False;
}
unsafe impl<T> Send for MyStruct<T>
where T: MyTrait<Project=True> {}
pub struct Wrapper {
inner: MyStruct<u8>
}

In this example, `::Project == True'
must hold for 'MyStruct: Send' to hold.
However, '::Project == False' holds instead

To properly account for this unusual case, we need to call
'poly_project_and_unify' on all predicates, not just those with
inference variables. This ensures that we catch the projection error
that occurs above, and don't incorrectly determine that 'Wrapper: Send'
holds.

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[hellow554]

Would you mind reducing the testcase a little bit?

pubstructTrue;pubstructFalse;pubtraitInterfaceType{typeSend;}pubstructFooInterface;pubstructDynTrait<I>(I);pubstructIntoIter(DynTrait<FooInterface>);implInterfaceTypeforFooInterface{typeSend = False;}unsafeimpl<I>SendforDynTrait<I>whereI:InterfaceType<Send = True>{}

[Dylan-DPC-zz]

ping from triage @eddyb waiting for your review on this

[eddyb]

I'm a bit dubious on this whole module but AFAIK it only affects rustdoc right now.

[eddyb]

cc @rust-lang/wg-traits You might want to review this change at some point (and the whole module - maybe it can be simplified/deduplicated with other parts of the trait system?)

@bors r+

[bors]

📌 Commit 476ea9e has been approved by eddyb