Uh oh!
There was an error while loading. Please reload this page.
upgrade rustdoc's pulldown-cmark to 0.5.2 - #60802
Conversation
rust-highfive
commented
May 13, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
May 14, 2019
There was a problem hiding this comment.
This might need a self.is_in check like the Event::Text arm.
It doesn't, since you can't create an inline code block outside of a paragraph or header.
We may want to hold off on this until pulldown-cmark/pulldown-cmark#325 is merged and released. |
marcusklaas
commented
May 27, 2019
The pull request has been merged and we're now preparing a bug fixing release (0.5.2). Shouldn't be more than a day or two. |
marcusklaas
commented
May 28, 2019
0.5.2 has been released! |
GuillaumeGomez
commented
May 29, 2019
@euclio You can update I guess? ;) |
pulldown-cmark to 0.5.1pulldown-cmark to 0.5.2euclio
commented
May 29, 2019
@GuillaumeGomez Updated. |
GuillaumeGomez
commented
May 29, 2019
Thanks! @bors: r+ |
bors
commented
May 29, 2019
📌 Commit ed8a4d5 has been approved by |
…laumeGomez upgrade rustdoc's `pulldown-cmark` to 0.5.2 Fixesrust-lang#60482.
Rollup of 11 pull requests Successful merges: - #60802 (upgrade rustdoc's `pulldown-cmark` to 0.5.2) - #60839 (Fix ICE with struct ctors and const generics.) - #60850 (Stabilize RefCell::try_borrow_unguarded) - #61231 (Fix linkage diagnostic so it doesn't ICE for external crates) - #61244 (Box::into_vec: use Box::into_raw instead of mem::forget) - #61279 (implicit `Option`-returning doctests) - #61280 (Revert "Disable solaris target since toolchain no longer builds") - #61284 (Update all s3 URLs used on CI with subdomains) - #61321 (libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.) - #61322 (ci: display more debug information in the init_repo script) - #61333 (Fix ICE with APIT in a function with a const parameter) Failed merges: - #61304 (Speed up Azure CI installing Windows dependencies) r? @ghost
Rollup of 11 pull requests Successful merges: - #60802 (upgrade rustdoc's `pulldown-cmark` to 0.5.2) - #60839 (Fix ICE with struct ctors and const generics.) - #60850 (Stabilize RefCell::try_borrow_unguarded) - #61231 (Fix linkage diagnostic so it doesn't ICE for external crates) - #61244 (Box::into_vec: use Box::into_raw instead of mem::forget) - #61279 (implicit `Option`-returning doctests) - #61280 (Revert "Disable solaris target since toolchain no longer builds") - #61284 (Update all s3 URLs used on CI with subdomains) - #61321 (libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.) - #61322 (ci: display more debug information in the init_repo script) - #61333 (Fix ICE with APIT in a function with a const parameter) Failed merges: - #61304 (Speed up Azure CI installing Windows dependencies) r? @ghost
jonas-schievink
commented
Jun 2, 2019
This also affects beta (and shows up a lot in the crater runs in #61401), nominating for backport |
QuietMisdreavus
commented
Jun 5, 2019
Accepting backport nomination. |
[beta] Rollup backports Rolled up: * [beta] Permit unwinding through FFI by default #61569 Cherry-picked: * upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802 * Fix overflowing literal lint in loops #61098 * Revert edition-guide toolstate override #61110 * Turn turbo 🐟 🍨 into an error #61189 * Bump hashbrown to 0.4.0 #61388 * Fix regression 61475 #61500 r? @ghost
[beta] Rollup backports Rolled up: * [beta] Permit unwinding through FFI by default #61569 Cherry-picked: * upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802 * Fix overflowing literal lint in loops #61098 * Revert edition-guide toolstate override #61110 * Turn turbo 🐟 🍨 into an error #61189 * Bump hashbrown to 0.4.0 #61388 * Fix regression 61475 #61500 r? @ghost
Fixes#60482.