Use `Symbol` more in lint APIs by oli-obk · Pull Request #60827 · rust-lang/rust

oli-obk · 2019-05-14T14:00:10Z

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky match_def_path function that I added and go back to calling rustc's match_def_path method.

nnethercote · 2019-05-14T22:33:40Z

@bors r+

But we need to coordinate... I'm working on more Symbol changes, e.g. #60815. I'm doing some ad hoc profiling to work out which ones are likely to affect performance. If we have multiple people doing these conversions there's a good chance there will be overlap.

bors · 2019-05-14T22:33:41Z

📌 Commit 1107158 has been approved by nnethercote

oli-obk · 2019-05-15T08:12:49Z

Yes, I tried not to touch anything else out of that reason. I did this just to remove hacks from clippy

@nnethercote

Use `Symbol` more in lint APIs r? @nnethercote This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.

@ghost

Rollup of 9 pull requests Successful merges: - #59825 (string: implement From<&String> for String) - #59923 (Fix convert module's documentation links) - #60691 (Include expression to wait for to the span of Await) - #60763 (Move token tree related lexer state to a separate struct) - #60769 (Update rustc book CLI docs.) - #60811 (Bump measureme dependency to 0.3) - #60816 (README.md: Mention MSVC 2017+, not 2013(!)) - #60827 (Use `Symbol` more in lint APIs) - #60851 (Move `box` from the stable keyword to unstable keywords list) Failed merges: r? @ghost

Centril · 2019-05-15T20:37:34Z

Toolstate breakage in #60859 (comment), @bors r-

bors · 2019-05-20T03:37:57Z

☔ The latest upstream changes (presumably #60969) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2019-05-27T08:28:03Z

@bors r=nnethercote

bors · 2019-05-27T08:28:04Z

📌 Commit 254b9240b3608e3509a125af0f0b0cd0370109d1 has been approved by nnethercote

bors · 2019-05-27T09:50:42Z

☔ The latest upstream changes (presumably #61035) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2019-05-27T10:29:17Z

@bors r=nnethercote

bors · 2019-05-27T10:29:18Z

📌 Commit d6ca34c has been approved by nnethercote

@nnethercote

Use `Symbol` more in lint APIs r? @nnethercote This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.

bors · 2019-05-27T15:36:40Z

⌛ Testing commit d6ca34c with merge fa40a11...

@nnethercote

Use `Symbol` more in lint APIs r? @nnethercote This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.

bors · 2019-05-27T18:26:11Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: nnethercote
Pushing fa40a11 to master...

rust-highfive · 2019-05-27T18:27:17Z

📣 Toolstate changed by #60827!

Tested on commit fa40a11.
Direct link to PR: #60827

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

@Manishearth

Tested on commit rust-lang/rust@fa40a11. Direct link to PR: <rust-lang/rust#60827> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

jonas-schievink added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2019

This was referenced May 15, 2019
Rollup of 6 pull requests #60843
Closed
Rollup of 6 pull requests #60844
Closed

Centril mentioned this pull request May 15, 2019
Rollup of 9 pull requests #60859
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2019

oli-obk force-pushed the late_symbol branch from 1107158 to 254b924Compare May 25, 2019 21:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 27, 2019

Use Symbol more in lint APIs
d6ca34c

oli-obk force-pushed the late_symbol branch from 254b924 to d6ca34cCompare May 27, 2019 10:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2019

Centril mentioned this pull request May 27, 2019
Rollup of 5 pull requests #61234
Closed

bors mentioned this pull request May 27, 2019
Bump nightly to 1.37.0 #61078
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2019

bors merged commit d6ca34c into rust-lang:masterMay 27, 2019

rust-highfive mentioned this pull request May 27, 2019
rls no longer builds after rust-lang/rust#60827 #61240
Closed

bors mentioned this pull request May 27, 2019
Add a "diagnostic item" scheme for lints referring to libstd items #60966
Merged

oli-obk deleted the late_symbol branch March 16, 2021 12:13

Uh oh!

Uh oh!

Conversation

oli-obk commented May 14, 2019

Uh oh!

nnethercote commented May 14, 2019

Uh oh!

bors commented May 14, 2019

Uh oh!

oli-obk commented May 15, 2019

Uh oh!

Centril commented May 15, 2019

Uh oh!

bors commented May 20, 2019

Uh oh!

oli-obk commented May 27, 2019

Uh oh!

bors commented May 27, 2019

Uh oh!

bors commented May 27, 2019

Uh oh!

oli-obk commented May 27, 2019

Uh oh!

bors commented May 27, 2019

Uh oh!

bors commented May 27, 2019

Uh oh!

bors commented May 27, 2019

Uh oh!

rust-highfive commented May 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants