Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #60949
Merged
Merged
Conversation
These `into_iter()` calls will change from iterating references to values if we ever get `IntoIterator` for arrays, which may break the code using that iterator. Calling `iter()` is future proof.
…, r=sfackler Mark core::alloc::Layout::from_size_align_unchecked const Makes it possible (pending stabilization of rust-lang#57563 (`const_fn`)) to rewrite code like ```rust const BUFFER_SIZE: usize = 0x2000; const BUFFER_ALIGN: usize = 0x1000; fn foo() { let layout = std::alloc::Layout::from_size_align(BUFFER_SIZE, BUFFER_ALIGN) .unwrap(); let buffer = std::alloc::alloc(layout); } ``` to ```rust const BUFFER_LAYOUT: std::alloc::Layout = unsafe { std::alloc::Layout::from_size_align_unchecked(0x2000, 0x1000) }; fn foo() { let buffer = std::alloc::alloc(BUFFER_LAYOUT); } ``` which (although `unsafe` is used) looks somewhat cleaner and is easier to read.
Stabilize vecdeque_rotate This PR stabilizes the vecdeque_rotate feature. r? @scottmcmClosesrust-lang#56686
Explain that ? converts the error type using From Fixrust-lang#60917.
Use iter() for iterating arrays by slice These `into_iter()` calls will change from iterating references to values if we ever get `IntoIterator` for arrays, which may break the code using that iterator. Calling `iter()` is future proof.
…e_macro, r=petrochenkov Declare DefIndex with the newtype_index macro See rust-lang#60666
fix copy-paste typo in docs for ptr::read_volatile
…=shepmaster Simplify BufRead::fill_buf doc example using NLL With non-lexical lifetimes, in this example it is no longer necessary to use a block to end the borrow early.
…schievink Fix typos in docs of GlobalAlloc
Centril
commented
May 19, 2019
ContributorAuthor
@bors r+ p=8 |
bors
commented
May 19, 2019
Collaborator
📌 Commit 9389c69 has been approved by |
Centril
commented
May 19, 2019
ContributorAuthor
@bors rollup=never |
bors
commented
May 19, 2019
Collaborator
bors added a commit
that referenced
this pull request
May 19, 2019
Rollup of 8 pull requests Successful merges: - #60370 (Mark core::alloc::Layout::from_size_align_unchecked const) - #60678 (Stabilize vecdeque_rotate) - #60924 (Explain that ? converts the error type using From) - #60931 (Use iter() for iterating arrays by slice) - #60934 (Declare DefIndex with the newtype_index macro) - #60943 (fix copy-paste typo in docs for ptr::read_volatile) - #60945 (Simplify BufRead::fill_buf doc example using NLL) - #60947 (Fix typos in docs of GlobalAlloc) Failed merges: r? @ghost
bors
commented
May 19, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
This was referenced May 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost