Skip to content

rustc: Improve type size assertions - #60959

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:sassert
May 21, 2019
Merged

rustc: Improve type size assertions#60959
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:sassert

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Now they

  • Tell what the new size is, when it changes
  • Do not require passing an identifier
 ::: src\libsyntax\parse\token.rs:223:1
|
223 | static_assert_size!(Token, 123);
| -------------------------------- in this macro invocation
|
= note: expected type `[(); 123]`
found type `[(); 16]`

Now they
- Tell what the new size is, when it changes
- Do not require passing an identifier
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2019
@estebank

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 20, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 88fa5c6 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2019
Centril added a commit to Centril/rust that referenced this pull request May 20, 2019
rustc: Improve type size assertions
Now they
- Tell what the new size is, when it changes
- Do not require passing an identifier
```
::: src\libsyntax\parse\token.rs:223:1
|
223 | static_assert_size!(Token, 123);
| -------------------------------- in this macro invocation
|
= note: expected type `[(); 123]`
found type `[(); 16]`
```
@CentrilCentril mentioned this pull request May 20, 2019
bors added a commit that referenced this pull request May 20, 2019
Rollup of 11 pull requests
Successful merges:
- #60383 (Fix position source code files toggle)
- #60453 (Fall back to `/dev/urandom` on `EPERM` for `getrandom`)
- #60487 (Fix search sidebar width when no crate select is present)
- #60511 (Fix intra-doc link resolution failure on re-exporting libstd)
- #60823 (Fix incremental compilation of cdylib emitting spurious unused_attributes lint)
- #60915 (stable hashing: Remove unused field and add documentation.)
- #60942 (Misc changes to rustc_metadata)
- #60952 (Document BinaryHeap time complexity)
- #60959 (rustc: Improve type size assertions)
- #60972 (remove confusing remarks about mixed volatile and non-volatile accesses)
- #60983 (Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind)
Failed merges:
r? @ghost
@bors
bors merged commit 88fa5c6 into rust-lang:masterMay 21, 2019
@petrochenkov
petrochenkov deleted the sassert branch June 5, 2019 16:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@petrochenkov@rust-highfive@estebank@bors