Uh oh!
There was an error while loading. Please reload this page.
Stop using gensyms in HIR lowering - #60960
Merged
Merged
Conversation
These names aren't ever handled by resolve, so there's no reason to make them gensyms.
petrochenkov
commented
May 19, 2019
Contributor
Thanks! |
bors
commented
May 19, 2019
Collaborator
📌 Commit 6bb3980 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
May 19, 2019
…m, r=petrochenkov Stop using gensyms in HIR lowering These names aren't ever handled by resolve, so there's no reason to make them gensyms. Diagnostics wanting to behave differently for these variables should inspect either the `MatchSource`/`LocalSource` or the `Span`. All current diagnostics appear to do this. r? @petrochenkov
bors added a commit
that referenced
this pull request
May 20, 2019
Rollup of 6 pull requests Successful merges: - #60590 (Test interaction of unions with non-zero/niche-filling optimization) - #60745 (Perform constant propagation into terminators) - #60895 (Enable thumbv7a-pc-windows-msvc target build end to end in rust/master) - #60908 (Fix lints handling in rustdoc) - #60960 (Stop using gensyms in HIR lowering) - #60962 (Fix data types indication) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These names aren't ever handled by resolve, so there's no reason to
make them gensyms.
Diagnostics wanting to behave differently for these variables should
inspect either the
MatchSource/LocalSourceor theSpan. Allcurrent diagnostics appear to do this.
r? @petrochenkov