Skip to content

Remove impls for InternedString/string equality. - #61003

Merged
bors merged 1 commit into
rust-lang:masterfrom
nnethercote:rm-InternedString-PartialEq-impls
May 22, 2019
Merged

Remove impls for InternedString/string equality.#61003
bors merged 1 commit into
rust-lang:masterfrom
nnethercote:rm-InternedString-PartialEq-impls

Conversation

@nnethercote

@nnethercotennethercote commented May 21, 2019

Copy link
Copy Markdown
Contributor

Symbol received the same treatment in #60630.

Also, we can derive PartialEq for InternedString.

r? @petrochenkov

@nnethercote
Remove impls for InternedString/string equality.
b557567
`Symbol` received the same treatment in rust-lang#60630.
Also, we can derive `PartialEq` for `InternedString`.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2019
@nnethercote

nnethercote commented May 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit b557567 with merge 0f90b7b859c08fbf9807af5984090f26297e5933...

@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@rust-highfive

rust-highfive commented May 21, 2019

Copy link
Copy Markdown
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services
travis_fold:start:git.checkout
travis_time:start:12b7d074
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
Cloning into 'rust-lang/rust'...
travis_time:end:12b7d074:start=1558433607451298324,finish=1558433613657120363,duration=6205822039
$ cd rust-lang/rust
$ git checkout -qf 0f90b7b859c08fbf9807af5984090f26297e5933
fatal: reference is not a tree: 0f90b7b859c08fbf9807af5984090f26297e5933
The command "git checkout -qf 0f90b7b859c08fbf9807af5984090f26297e5933" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2019
@nnethercote

nnethercote commented May 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit b557567 with merge ec4deee08e13106e7de91b1b630c63ae2774d6c1...

@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@rust-highfive

rust-highfive commented May 21, 2019

Copy link
Copy Markdown
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services
travis_fold:start:git.checkout
travis_time:start:0783d488
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
Cloning into 'rust-lang/rust'...
travis_time:end:0783d488:start=1558435113273512685,finish=1558435119334606568,duration=6061093883
$ cd rust-lang/rust
$ git checkout -qf ec4deee08e13106e7de91b1b630c63ae2774d6c1
fatal: reference is not a tree: ec4deee08e13106e7de91b1b630c63ae2774d6c1
The command "git checkout -qf ec4deee08e13106e7de91b1b630c63ae2774d6c1" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nnethercote

nnethercote commented May 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit b557567 with merge 041ca93...

bors added a commit that referenced this pull request May 21, 2019
@bors
Auto merge of#61003- nnethercote:rm-InternedString-PartialEq-impls,…
041ca93
… r=<try>
Remove impls for `InternedString`/string equality.
`Symbol` received the same treatment in #60630.
Also, we can derive `PartialEq` for `InternedString`.
r? @petrochenkov
@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-travis
Build commit: 041ca93

@petrochenkov

petrochenkov commented May 21, 2019

Copy link
Copy Markdown
Contributor

@rust-timer build 041ca93

@rust-timer

rust-timer commented May 21, 2019

Copy link
Copy Markdown
Collaborator

Success: Queued 041ca93 with parent 50a0def, comparison URL.

@petrochenkov

petrochenkov commented May 21, 2019

Copy link
Copy Markdown
Contributor

r=me once perf run is complete

@petrochenkovpetrochenkov added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2019
@rust-timer

rust-timer commented May 21, 2019

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit 041ca93: comparison url

@nnethercote

nnethercote commented May 21, 2019

Copy link
Copy Markdown
ContributorAuthor

It's a slight perf win.

@bors r=petrochenkov

@bors

bors commented May 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit b557567 has been approved by petrochenkov

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 21, 2019
@petrochenkovpetrochenkov removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 22, 2019
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
@Centril
Rollup merge ofrust-lang#61003- nnethercote:rm-InternedString-Parti…
4ab7a0e
…alEq-impls, r=petrochenkov
Remove impls for `InternedString`/string equality.
`Symbol` received the same treatment in rust-lang#60630.
Also, we can derive `PartialEq` for `InternedString`.
r? @petrochenkov
@CentrilCentril mentioned this pull request May 22, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
@Centril
Rollup merge ofrust-lang#61003- nnethercote:rm-InternedString-Parti…
44cb86b
…alEq-impls, r=petrochenkov
Remove impls for `InternedString`/string equality.
`Symbol` received the same treatment in rust-lang#60630.
Also, we can derive `PartialEq` for `InternedString`.
r? @petrochenkov
@CentrilCentril mentioned this pull request May 22, 2019
Merged
bors added a commit that referenced this pull request May 22, 2019
@bors
Auto merge of#61027- Centril:rollup-oewauf1, r=Centril
dbfe70d
Rollup of 10 pull requests
Successful merges:
- #59742 (Move `edition` outside the hygiene lock and avoid accessing it)
- #60581 (convert custom try macro to `?`)
- #60963 (Update boxed::Box docs on memory layout)
- #60973 (Avoid symbol interning in `file_metadata`.)
- #60982 (Do not fail on child without DefId)
- #60991 (LocalDecl push returns Local len)
- #60995 (Add stream_to_parser_with_base_dir)
- #60998 (static_assert: make use of anonymous constants)
- #61003 (Remove impls for `InternedString`/string equality.)
- #61006 (adjust deprecation date of mem::uninitialized)
Failed merges:
r? @ghost
@bors
bors merged commit b557567 into rust-lang:masterMay 22, 2019
@nnethercote
nnethercote deleted the rm-InternedString-PartialEq-impls branch May 22, 2019 23:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nnethercote@bors@rust-highfive@petrochenkov@rust-timer