Move path for iterate by spastorino · Pull Request #61102 · rust-lang/rust

spastorino · 2019-05-23T23:10:20Z

rust-highfive · 2019-05-23T23:27:06Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:105ef9d0:start=1558653082075204258,finish=1558653082828612683,duration=753408425
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:04:50] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:51] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:145: line longer than 100 chars
[00:04:56] some tidy checks failed
[00:04:56] [00:04:56] [00:04:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:56] [00:04:56] [00:04:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:56] Build completed unsuccessfully in 0:01:17
[00:04:56] Build completed unsuccessfully in 0:01:17
[00:04:56] Makefile:67: recipe for target 'tidy' failed
[00:04:56] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:16a4965c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May 23 23:16:29 UTC 2019
---
travis_time:end:0172d638:start=1558653390553996011,finish=1558653390559190203,duration=5194192
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:16ead4c3
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0c503c40
travis_time:start:0c503c40
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02cada9d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-05-24T17:22:43Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0b4c7c0c:start=1558716778630855058,finish=1558716868372606532,duration=89741751474
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:27:38] Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/flt2dec/mod.rs:193:25
[00:27:53] |
[00:27:53] 193 | for c in &mut out[..nzeroes] { *c = b'0'; }
[00:27:53] | ^ value moved here, in previous iteration of loop
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/flt2dec/mod.rs:196:25
[00:27:53] |
[00:27:53] |
[00:27:53] 196 | for c in out[..len].iter_mut().rev() {
[00:27:53] | ^ value moved here, in previous iteration of loop
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/flt2dec/strategy/dragon.rs:279:21
[00:27:53] |
[00:27:53] |
[00:27:53] 279 | for c in &mut buf[i..len] { *c = b'0'; }
[00:27:53] | ^ value moved here, in previous iteration of loop
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:253:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 253 | | for a in &mut self.base[..sz] {
[00:27:53] | | ^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 481 | define_bignum!(Big32x40: type=Digit32, n=40);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u32`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:253:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 253 | | for a in &mut self.base[..sz] {
[00:27:53] | | ^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 486 | define_bignum!(Big8x3: type=u8, n=3);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:384:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 384 | | for a in self.base[..sz].iter_mut().rev() {
[00:27:53] | | ^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 481 | define_bignum!(Big32x40: type=Digit32, n=40);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u32`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:384:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 384 | | for a in self.base[..sz].iter_mut().rev() {
[00:27:53] | | ^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 486 | define_bignum!(Big8x3: type=u8, n=3);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:402:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 402 | | for digit in &mut q.base[..] {
[00:27:53] | | ^^^^^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 481 | define_bignum!(Big32x40: type=Digit32, n=40);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u32`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:405:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 405 | | for digit in &mut r.base[..] {
[00:27:53] | | ^^^^^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 481 | define_bignum!(Big32x40: type=Digit32, n=40);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u32`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:402:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 402 | | for digit in &mut q.base[..] {
[00:27:53] | | ^^^^^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 486 | define_bignum!(Big8x3: type=u8, n=3);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:53] error[E0382]: use of moved value
[00:27:53] --> src/libcore/num/bignum.rs:405:21
[00:27:53] |
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 100 | / macro_rules! define_bignum {
[00:27:53] 101 | | ($name:ident: type=$ty:ty, n=$n:expr) => (
[00:27:53] 102 | | /// Stack-allocated arbitrary-precision (up to certain limit) integer.
[00:27:53] ... |
[00:27:53] ... |
[00:27:53] 405 | | for digit in &mut r.base[..] {
[00:27:53] | | ^^^^^ value moved here, in previous iteration of loop
[00:27:53] 475 | | )
[00:27:53] 476 | | }
[00:27:53] | |_- in this expansion of `define_bignum!`
[00:27:53] ...
[00:27:53] ...
[00:27:53] 486 | define_bignum!(Big8x3: type=u8, n=3);
[00:27:53] |
[00:27:53] |
[00:27:53] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:54] error[E0381]: use of possibly uninitialized variable: `_`
[00:27:54] --> src/libcore/cell.rs:821:15
[00:27:54] |
[00:27:54] |
[00:27:54] 821 | match BorrowRef::new(&self.borrow) {
[00:27:54] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of possibly uninitialized value
[00:27:54] error[E0381]: use of possibly uninitialized variable: `_`
[00:27:54] --> src/libcore/cell.rs:899:15
[00:27:54] |
[00:27:54] |
[00:27:54] 899 | match BorrowRefMut::new(&self.borrow) {
[00:27:54] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of possibly uninitialized value
[00:27:55] error[E0382]: use of moved value
[00:27:55] --> src/libcore/slice/mod.rs:2520:13
[00:27:55] |
[00:27:55] 2520 | for byte in self {
[00:27:55] 2520 | for byte in self {
[00:27:55] | ^^^^ value moved here, in previous iteration of loop
[00:27:55] |
[00:27:55] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:55] error[E0382]: use of moved value
[00:27:55] --> src/libcore/slice/mod.rs:2537:13
[00:27:55] |
[00:27:55] 2537 | for byte in self {
[00:27:55] 2537 | for byte in self {
[00:27:55] | ^^^^ value moved here, in previous iteration of loop
[00:27:55] |
[00:27:55] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:55] error[E0382]: use of moved value
[00:27:55] --> src/libcore/slice/mod.rs:3158:32
[00:27:55] |
[00:27:55] 3015 | / macro_rules! iterator {
[00:27:55] 3015 | / macro_rules! iterator {
[00:27:55] 3016 | | (
[00:27:55] 3017 | | struct $name:ident -> $ptr:ty,
[00:27:55] 3018 | | $elem:ty,
[00:27:55] 3158 | | while let Some(x) = self.next() {
[00:27:55] 3158 | | while let Some(x) = self.next() {
[00:27:55] | | ^ value moved here, in previous iteration of loop
[00:27:55] 3261 | | }
[00:27:55] 3262 | | }
[00:27:55] | |_- in this expansion of `iterator!`
[00:27:55] ...
[00:27:55] ...
[00:27:55] 3477 | iterator!{struct IterMut -> *mut T, &'a mut T, mut, {mut}, {}}
[00:27:55] |
[00:27:55] |
[00:27:55] = note: move occurs because value has type `&mut T`, which does not implement the `Copy` trait
[00:27:55] error[E0382]: use of moved value
[00:27:55] --> src/libcore/slice/mod.rs:3249:32
[00:27:55] |
[00:27:55] 3015 | / macro_rules! iterator {
[00:27:55] 3015 | / macro_rules! iterator {
[00:27:55] 3016 | | (
[00:27:55] 3017 | | struct $name:ident -> $ptr:ty,
[00:27:55] 3018 | | $elem:ty,
[00:27:55] 3249 | | while let Some(x) = self.next_back() {
[00:27:55] 3249 | | while let Some(x) = self.next_back() {
[00:27:55] | | ^ value moved here, in previous iteration of loop
[00:27:55] 3261 | | }
[00:27:55] 3262 | | }
[00:27:55] | |_- in this expansion of `iterator!`
[00:27:55] ...
[00:27:55] ...
[00:27:55] 3477 | iterator!{struct IterMut -> *mut T, &'a mut T, mut, {mut}, {}}
[00:27:55] |
[00:27:55] |
[00:27:55] = note: move occurs because value has type `&mut T`, which does not implement the `Copy` trait
[00:27:56] error[E0382]: use of moved value
[00:27:56] --> src/libcore/fmt/mod.rs:1397:25
[00:27:56] |
[00:27:56] |
[00:27:56] 1397 | for c in s[..len].iter_mut().rev() {
[00:27:56] | ^ value moved here, in previous iteration of loop
[00:27:56] |
[00:27:56] = note: move occurs because value has type `&mut u8`, which does not implement the `Copy` trait
[00:27:56] error[E0382]: use of moved value
[00:27:56] error[E0382]: use of moved value
[00:27:56] --> src/libcore/fmt/num.rs:60:17
[00:27:56] |
[00:27:56] 60 | for byte in buf.iter_mut().rev() {
[00:27:56] | ^^^^ value moved here, in previous iteration of loop
[00:27:56] |
[00:27:56] = note: move occurs because value has type `&mut mem::MaybeUninit<u8>`, which does not implement the `Copy` trait
[00:27:56] error[E0382]: use of moved value
[00:27:56] error[E0382]: use of moved value
[00:27:56] --> src/libcore/fmt/num.rs:72:17
[00:27:56] |
[00:27:56] 72 | for byte in buf.iter_mut().rev() {
[00:27:56] | ^^^^ value moved here, in previous iteration of loop
[00:27:56] |
[00:27:56] = note: move occurs because value has type `&mut mem::MaybeUninit<u8>`, which does not implement the `Copy` trait
[00:27:58] error: aborting due to 20 previous errors
[00:27:58] [00:27:58] Some errors have detailed explanations: E0381, E0382.
[00:27:58] For more information about an error, try `rustc --explain E0381`.
---
travis_time:end:02ba651a:start=1558718558630482420,finish=1558718558636830412,duration=6347992
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04345324
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02e6c09c
travis_time:start:02e6c09c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2100f086
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-05-24T22:49:46Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0911bacb:start=1558736622237679217,finish=1558736710156333223,duration=87918654006
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:21:17] Compiling rustc_typeck v0.0.0 (/checkout/src/librustc_typeck)
[00:21:26] error[E0308]: mismatched types
[00:21:26] --> src/librustc_mir/dataflow/move_paths/builder.rs:160:47
[00:21:26] |
[00:21:26] 160 | Place::Projection(PlaceProjection {
[00:21:26] | _______________________________________________^
[00:21:26] 161 | | base: proj.base,
[00:21:26] 162 | | elem: proj.elem.clone(),
[00:21:26] 163 | | }),
[00:21:26] | |_____________________________^ expected struct `std::boxed::Box`, found struct `rustc::mir::Projection`
[00:21:26] |
[00:21:26] = note: expected type `std::boxed::Box<rustc::mir::Projection<rustc::mir::Place<'_>, _, &rustc::ty::TyS<'_>>>`
[00:21:26] found type `rustc::mir::Projection<rustc::mir::Place<'_>, _, &rustc::ty::TyS<'_>>`
[00:21:32] error: aborting due to previous error
[00:21:32] [00:21:32] For more information about this error, try `rustc --explain E0308`.
[00:21:32] error: Could not compile `rustc_mir`.
---
travis_time:end:0b4c94e1:start=1558738181822378342,finish=1558738181827317822,duration=4939480
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0e3150e8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:39cbd822
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-05-25T04:22:49Z

☔ The latest upstream changes (presumably #60441) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2019-05-26T07:24:05Z

@bors r+

bors · 2019-05-26T07:24:07Z

📌 Commit 294dc18 has been approved by oli-obk

@oli-obk

…=oli-obk Move path for iterate r? @oli-obk

@ghost

Rollup of 4 pull requests Successful merges: - #61077 (Don't arena-allocate static symbols.) - #61102 (Move path for iterate) - #61120 (Make eval_place iterate instead of recurse) - #61205 (docs: fix typo #61197) Failed merges: r? @ghost

rust-highfive assigned oli-obk May 23, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2019

oli-obk reviewed May 24, 2019
View reviewed changes

Comment threadsrc/librustc_mir/dataflow/move_paths/builder.rs Outdated

spastorino force-pushed the move-path-for-iterate branch from 67432a3 to 8edd3d0Compare May 24, 2019 22:22

spastorino force-pushed the move-path-for-iterate branch 2 times, most recently from f424306 to 83a38b7Compare May 25, 2019 00:29

oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2019

Inline move_path_for_projection inside move_path_for
a0700d0

spastorino force-pushed the move-path-for-iterate branch from 83a38b7 to 3161f41Compare May 25, 2019 22:30

oli-obk reviewed May 25, 2019
View reviewed changes

Comment threadsrc/librustc_mir/dataflow/move_paths/builder.rs Outdated

oli-obk reviewed May 25, 2019
View reviewed changes

Comment threadsrc/librustc_mir/dataflow/move_paths/builder.rs Outdated

Make move_path_for iterate instead of recurse
294dc18

spastorino force-pushed the move-path-for-iterate branch from 3161f41 to 294dc18Compare May 25, 2019 22:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2019

Centril added a commit to Centril/rust that referenced this pull request May 26, 2019
Rollup merge ofrust-lang#61102- spastorino:move-path-for-iterate, r…
a40b82b
…=oli-obk Move path for iterate r? @oli-obk

Centril mentioned this pull request May 26, 2019
Rollup of 4 pull requests #61210
Merged

bors merged commit 294dc18 into rust-lang:masterMay 26, 2019

Navigation Menu

Uh oh!

Uh oh!

Move path for iterate - #61102

Move path for iterate#61102
bors merged 2 commits into
rust-lang:masterfrom
spastorino:move-path-for-iterate

spastorino commented May 23, 2019

Uh oh!

rust-highfive commented May 23, 2019

Uh oh!

rust-highfive commented May 24, 2019

Uh oh!

Uh oh!

rust-highfive commented May 24, 2019

Uh oh!

bors commented May 25, 2019

Uh oh!

Uh oh!

Uh oh!

oli-obk commented May 26, 2019

Uh oh!

bors commented May 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

spastorino commented May 23, 2019

Uh oh!

rust-highfive commented May 23, 2019

Uh oh!

rust-highfive commented May 24, 2019

Uh oh!

Uh oh!

rust-highfive commented May 24, 2019

Uh oh!

bors commented May 25, 2019

Uh oh!

Uh oh!

Uh oh!

oli-obk commented May 26, 2019

Uh oh!

bors commented May 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants