Warn on bare_trait_objects by default by memoryruins · Pull Request #61203 · rust-lang/rust

memoryruins · 2019-05-26T02:44:42Z

The bare_trait_objects lint is set to warn by default.
Most ui tests have been updated to use dyn to avoid creating noise in stderr files.

r? @Centril

cc #54910

memoryruins · 2019-05-26T06:37:48Z

and now for level 2: updating run-pass suite.

memoryruins · 2019-05-28T05:06:28Z

@Centril ready for review! \o/

Centril · 2019-05-28T13:50:03Z

@rust-lang/lang N.B. This PR implements the "lint against bare trait syntax" as specified in RFC 2113. As we only move to a warning, I think we can dispense with a crater run for now and perhaps move to deny later in the year.

joshtriplett · 2019-05-28T15:03:26Z

On Tue, May 28, 2019 at 06:51:30AM -0700, Mazdak Farrokhzad wrote: @rust-lang/lang N.B. This PR implements the *"lint against bare trait syntax"* as specified in [RFC 2113](https://github.com/Ixrec/rfcs/blob/dyn-trait-syntax/text/2113-dyn-trait-syntax.md#migration). As we only move to a warning, I think we can dispense with a crater run for now and perhaps move to `deny` later in the year.

Note that under normal circumstances, I'd say we need a crater run to assess the impact of even a new warning, as that *can* cause build failures (`deny(warnings)`). However, as this was announced and advertised as part of the Rust 2018 edition, I think we can reasonably introduce it as an idiom lint, to be enabled as part of that family of lints.

memoryruins · 2019-05-28T20:53:44Z

Rebased on top of master and addressed comments ^^

Centril · 2019-05-28T21:00:24Z

Thanks!

@bors r+ p=1 rollup=never

bors · 2019-05-28T21:00:25Z

📌 Commit a6eda0d1b841e18235575b4977435cf78ab711a3 has been approved by Centril

Centril · 2019-05-28T22:22:38Z

@bors p=2

bors · 2019-05-29T01:58:35Z

⌛ Testing commit a6eda0d1b841e18235575b4977435cf78ab711a3 with merge f4d9baf059c86bacc6e25f38308f409c808f0cf9...

bors · 2019-05-29T03:38:07Z

💔 Test failed - checks-travis

@oli-obk

submodules: update clippy from fb33fad to d2f5122 Changes: ```` Rustup to #61203 rustup #60928 rustup #61164 (which is included in #61274) ```` Fixes#61287 r? @oli-obk

alexcrichton · 2019-05-31T18:21:12Z

It appears that this lint isn't automatically rust-fixable, is that correct?

If so I would prefer that this were reverted, it's generating thousands of warnings in just one local project, and without rustfix to fix the majority of these it seems like this is prematurely warning by default.

Centril · 2019-05-31T18:25:56Z

It appears that this lint isn't automatically rust-fixable, is that correct?

I was able to rustfix this automatically in rust-lang/gll#100. Did you use cargo fix --edition-idioms? dyn Trait is even included as an example in the edition guide, https://doc.rust-lang.org/nightly/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html#writing-idiomatic-code-in-a-new-edition

alexcrichton · 2019-05-31T18:34:41Z

Since this is now an on-by-default warning it should not require --edition-idioms. It'd be great to make sure that these things are tested before landing.

Tweaking the cargo fix command locally it does look like these are automatically fixed, namely for me using --all worked since it only looks to fix in the local package otherwise.

Centril · 2019-05-31T18:41:29Z

@alexcrichton Ah; I assumed the --edition-idioms infrastructure simply set -W rust_2018_idioms. Can you upstream the fix (in cargo I assume?)?

namely for me using --all worked since it only looks to fix in the local package otherwise.

But --cap-lints should apply so you shouldn't get warnings otherwise... or perhaps you had some interactions with macros?

Missing `dyn` for trait object (bare trait object) is a warning by default now as rust-lang/rust#61203 is merged, which breaks labrpc. Also fixed a few other warnings and unclear documents. Signed-off-by: Liqueur Librazy <im@librazy.org>

alexcrichton · 2019-06-03T14:17:31Z

No fix was necessary, it's simply on by default and all that's needed is cargo fix. If there is more than one crate in a workspace you may need cargo fix --all. The --cap-lints argument isn't applied to workspace members.

Missing `dyn` for trait object (bare trait object) is a warning by default now as rust-lang/rust#61203 is merged, which breaks labrpc. Also fixed a few other warnings and unclear documents. Signed-off-by: Liqueur Librazy <im@librazy.org>

SimonSapin · 2019-06-19T16:05:44Z

This change is proving disruptive: #61963

Pkgsrc changes: * Add a patch to llvm to deal with const dli_saddr. * Adapt two other patches. * Cross-build currently fails, so i386, powerpc and sparc64 bootstrap kits for 1.37.0 are built natively. Missing aarch64 hardware, so that's not available yet. * Bump bootstrap requirements to 1.36.0 except for armv7-unknown-netbsd-eabihf which I've not managed to cross-build. Upstream changes: Version 1.37.0 (2019-08-15) ========================== Language -------- - `#[must_use]` will now warn if the type is contained in a [tuple][61100], [`Box`][62228], or an [array][62235] and unused. - [You can now use the `cfg` and `cfg_attr` attributes on generic parameters.][61547] - [You can now use enum variants through type alias.][61682] e.g. You can write the following: ```rust type MyOption = Option<u8>; fn increment_or_zero(x: MyOption) -> u8 { match x { MyOption::Some(y) => y + 1, MyOption::None => 0, } } ``` - [You can now use `_` as an identifier for consts.][61347] e.g. You can write `const _: u32 = 5;`. - [You can now use `#[repr(align(X)]` on enums.][61229] - [The `?`/_"Kleene"_ macro operator is now available in the 2015 edition.][60932] Compiler -------- - [You can now enable Profile-Guided Optimization with the `-C profile-generate` and `-C profile-use` flags.][61268] For more information on how to use profile guided optimization, please refer to the [rustc book][rustc-book-pgo]. - [The `rust-lldb` wrapper script should now work again.][61827] Libraries --------- - [`mem::MaybeUninit<T>` is now ABI-compatible with `T`.][61802] Stabilized APIs --------------- - [`BufReader::buffer`] - [`BufWriter::buffer`] - [`Cell::from_mut`] - [`Cell<[T]>::as_slice_of_cells`][`Cell<slice>::as_slice_of_cells`] - [`DoubleEndedIterator::nth_back`] - [`Option::xor`] - [`Wrapping::reverse_bits`] - [`i128::reverse_bits`] - [`i16::reverse_bits`] - [`i32::reverse_bits`] - [`i64::reverse_bits`] - [`i8::reverse_bits`] - [`isize::reverse_bits`] - [`slice::copy_within`] - [`u128::reverse_bits`] - [`u16::reverse_bits`] - [`u32::reverse_bits`] - [`u64::reverse_bits`] - [`u8::reverse_bits`] - [`usize::reverse_bits`] Cargo ----- - [`Cargo.lock` files are now included by default when publishing executable crates with executables.][cargo/7026] - [You can now specify `default-run="foo"` in `[package]` to specify the default executable to use for `cargo run`.][cargo/7056] Misc ---- Compatibility Notes ------------------- - [Using `...` for inclusive range patterns will now warn by default.][61342] Please transition your code to using the `..=` syntax for inclusive ranges instead. - [Using a trait object without the `dyn` will now warn by default.][61203] Please transition your code to use `dyn Trait` for trait objects instead. [62228]: rust-lang/rust#62228 [62235]: rust-lang/rust#62235 [61802]: rust-lang/rust#61802 [61827]: rust-lang/rust#61827 [61547]: rust-lang/rust#61547 [61682]: rust-lang/rust#61682 [61268]: rust-lang/rust#61268 [61342]: rust-lang/rust#61342 [61347]: rust-lang/rust#61347 [61100]: rust-lang/rust#61100 [61203]: rust-lang/rust#61203 [61229]: rust-lang/rust#61229 [60932]: rust-lang/rust#60932 [cargo/7026]: rust-lang/cargo#7026 [cargo/7056]: rust-lang/cargo#7056 [`BufReader::buffer`]: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer [`BufWriter::buffer`]: https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.buffer [`Cell::from_mut`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.from_mut [`Cell<slice>::as_slice_of_cells`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.as_slice_of_cells [`DoubleEndedIterator::nth_back`]: https://doc.rust-lang.org/std/iter/trait.DoubleEndedIterator.html#method.nth_back [`Option::xor`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.xor [`RefCell::try_borrow_unguarded`]: https://doc.rust-lang.org/std/cell/struct.RefCell.html#method.try_borrow_unguarded [`Wrapping::reverse_bits`]: https://doc.rust-lang.org/std/num/struct.Wrapping.html#method.reverse_bits [`i128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i128.html#method.reverse_bits [`i16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i16.html#method.reverse_bits [`i32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i32.html#method.reverse_bits [`i64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i64.html#method.reverse_bits [`i8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i8.html#method.reverse_bits [`isize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.isize.html#method.reverse_bits [`slice::copy_within`]: https://doc.rust-lang.org/std/primitive.slice.html#method.copy_within [`u128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u128.html#method.reverse_bits [`u16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u16.html#method.reverse_bits [`u32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u32.html#method.reverse_bits [`u64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u64.html#method.reverse_bits [`u8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u8.html#method.reverse_bits [`usize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.usize.html#method.reverse_bits [rustc-book-pgo]: https://doc.rust-lang.org/rustc/profile-guided-optimization.html

When using Rust 1.37 a missing 'dyn' in conjunction with a trait object is now emitting a warning (see [Rust issue #61203][issue-61203]), causing all generated programs to warn as well: > warning: trait objects without an explicit `dyn` are deprecated > --> src/valmap.rs:36:34 > | > 36 | pub fn format(&self, w: &mut io::Write) -> io::Result<()> { > | ^^^^^^^^^ help: use `dyn`: `dyn io::Write` > | > = note: #[warn(bare_trait_objects)] on by default Let's remove these warnings by adding this keyword to the uses of trait objects in the project template. [issue-61203]: rust-lang/rust#61203

Using bare trait objects is deprecated and now triggers a warning by default: rust-lang/rust#61203.

Changes: ```` Rustup to rust-lang/rust#61203 rustup rust-lang/rust#60928 rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) ````

Using bare trait objects is deprecated and now triggers a warning by default: rust-lang/rust#61203.

Pkgsrc changes: * Add a patch to llvm to deal with const dli_saddr. * Adapt two other patches. * Cross-build currently fails, so i386, powerpc and sparc64 bootstrap kits for 1.37.0 are built natively. Missing aarch64 hardware, so that's not available yet. * Bump bootstrap requirements to 1.36.0 except for armv7-unknown-netbsd-eabihf which I've not managed to cross-build. Upstream changes: Version 1.37.0 (2019-08-15) ========================== Language -------- - `#[must_use]` will now warn if the type is contained in a [tuple][61100], [`Box`][62228], or an [array][62235] and unused. - [You can now use the `cfg` and `cfg_attr` attributes on generic parameters.][61547] - [You can now use enum variants through type alias.][61682] e.g. You can write the following: ```rust type MyOption = Option<u8>; fn increment_or_zero(x: MyOption) -> u8 { match x { MyOption::Some(y) => y + 1, MyOption::None => 0, } } ``` - [You can now use `_` as an identifier for consts.][61347] e.g. You can write `const _: u32 = 5;`. - [You can now use `#[repr(align(X)]` on enums.][61229] - [The `?`/_"Kleene"_ macro operator is now available in the 2015 edition.][60932] Compiler -------- - [You can now enable Profile-Guided Optimization with the `-C profile-generate` and `-C profile-use` flags.][61268] For more information on how to use profile guided optimization, please refer to the [rustc book][rustc-book-pgo]. - [The `rust-lldb` wrapper script should now work again.][61827] Libraries --------- - [`mem::MaybeUninit<T>` is now ABI-compatible with `T`.][61802] Stabilized APIs --------------- - [`BufReader::buffer`] - [`BufWriter::buffer`] - [`Cell::from_mut`] - [`Cell<[T]>::as_slice_of_cells`][`Cell<slice>::as_slice_of_cells`] - [`DoubleEndedIterator::nth_back`] - [`Option::xor`] - [`Wrapping::reverse_bits`] - [`i128::reverse_bits`] - [`i16::reverse_bits`] - [`i32::reverse_bits`] - [`i64::reverse_bits`] - [`i8::reverse_bits`] - [`isize::reverse_bits`] - [`slice::copy_within`] - [`u128::reverse_bits`] - [`u16::reverse_bits`] - [`u32::reverse_bits`] - [`u64::reverse_bits`] - [`u8::reverse_bits`] - [`usize::reverse_bits`] Cargo ----- - [`Cargo.lock` files are now included by default when publishing executable crates with executables.][cargo/7026] - [You can now specify `default-run="foo"` in `[package]` to specify the default executable to use for `cargo run`.][cargo/7056] Misc ---- Compatibility Notes ------------------- - [Using `...` for inclusive range patterns will now warn by default.][61342] Please transition your code to using the `..=` syntax for inclusive ranges instead. - [Using a trait object without the `dyn` will now warn by default.][61203] Please transition your code to use `dyn Trait` for trait objects instead. [62228]: rust-lang/rust#62228 [62235]: rust-lang/rust#62235 [61802]: rust-lang/rust#61802 [61827]: rust-lang/rust#61827 [61547]: rust-lang/rust#61547 [61682]: rust-lang/rust#61682 [61268]: rust-lang/rust#61268 [61342]: rust-lang/rust#61342 [61347]: rust-lang/rust#61347 [61100]: rust-lang/rust#61100 [61203]: rust-lang/rust#61203 [61229]: rust-lang/rust#61229 [60932]: rust-lang/rust#60932 [cargo/7026]: rust-lang/cargo#7026 [cargo/7056]: rust-lang/cargo#7056 [`BufReader::buffer`]: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer [`BufWriter::buffer`]: https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.buffer [`Cell::from_mut`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.from_mut [`Cell<slice>::as_slice_of_cells`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.as_slice_of_cells [`DoubleEndedIterator::nth_back`]: https://doc.rust-lang.org/std/iter/trait.DoubleEndedIterator.html#method.nth_back [`Option::xor`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.xor [`RefCell::try_borrow_unguarded`]: https://doc.rust-lang.org/std/cell/struct.RefCell.html#method.try_borrow_unguarded [`Wrapping::reverse_bits`]: https://doc.rust-lang.org/std/num/struct.Wrapping.html#method.reverse_bits [`i128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i128.html#method.reverse_bits [`i16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i16.html#method.reverse_bits [`i32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i32.html#method.reverse_bits [`i64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i64.html#method.reverse_bits [`i8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i8.html#method.reverse_bits [`isize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.isize.html#method.reverse_bits [`slice::copy_within`]: https://doc.rust-lang.org/std/primitive.slice.html#method.copy_within [`u128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u128.html#method.reverse_bits [`u16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u16.html#method.reverse_bits [`u32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u32.html#method.reverse_bits [`u64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u64.html#method.reverse_bits [`u8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u8.html#method.reverse_bits [`usize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.usize.html#method.reverse_bits [rustc-book-pgo]: https://doc.rust-lang.org/rustc/profile-guided-optimization.html

…fault now as rust-lang/rust#61203 is merged, which breaks labrpc.

rust-highfive assigned Centril May 26, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2019

This comment has been minimized.
Sign in to view

memoryruins force-pushed the bare_trait_objects branch 2 times, most recently from 2dc7a7a to 9eb7ad3Compare May 26, 2019 04:35

This comment has been minimized.
Sign in to view

memoryruins force-pushed the bare_trait_objects branch from 8596ee9 to cf792cbCompare May 26, 2019 18:33

This comment has been minimized.
Sign in to view

memoryruins force-pushed the bare_trait_objects branch from cf792cb to b03c80eCompare May 26, 2019 21:40

This comment has been minimized.
Sign in to view

memoryruins force-pushed the bare_trait_objects branch from 418e39b to afa2bd6Compare May 28, 2019 07:13

Centril suggested changes May 28, 2019
View reviewed changes

Set bare_trait_objects lint to warn
54e1055

memoryruins force-pushed the bare_trait_objects branch from afa2bd6 to a6eda0dCompare May 28, 2019 18:44

Update test/ui/parser for bare_trait_object warnings
a1d1d7a

Centril approved these changes May 28, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2019

memoryruins mentioned this pull request May 30, 2019
Tracking issue for warning for rust_2018_idioms by default #54910
Open
11 tasks

Librazy mentioned this pull request Jun 2, 2019
Fix labrpc building for Rust Nightly pingcap/talent-plan#133
Merged

ehuss mentioned this pull request Jun 2, 2019
Fix bare_trait_objects warning. rust-lang/git2-rs#426
Merged

shssoichiro mentioned this pull request Jun 5, 2019
Use dyn for a dynamic trait xiph/rav1e#1332
Merged

ehuss mentioned this pull request Aug 6, 2019
Update tests for bare_trait_objects warning. rust-lang/rustfix#172
Merged

MarcoPolo mentioned this pull request Sep 10, 2019
Fix dyn issues on 1.37 maidsafe-archive/crust#1159
Open

petreeftime mentioned this pull request Sep 22, 2019
Fix warnings with rust 1.37 firecracker-microvm/firecracker#1277
Merged
7 tasks

memoryruins mentioned this pull request Nov 11, 2019
Suggest to add lifetime constraint at explicit ouput of functions #65730
Merged

remi-dupre added a commit to Qwant/fafnir that referenced this pull request Nov 18, 2019
add explicit dyn when using trait objects
8f4695f
Using bare trait objects is deprecated and now triggers a warning by default: rust-lang/rust#61203.

remi-dupre mentioned this pull request Nov 18, 2019
add explicit dyn when using trait objects Qwant/fafnir#35
Merged

remi-dupre added a commit to Qwant/fafnir that referenced this pull request Nov 19, 2019
add explicit dyn when using trait objects
1adc547
Using bare trait objects is deprecated and now triggers a warning by default: rust-lang/rust#61203.

Julian-Wollersberger mentioned this pull request Jan 25, 2021
Change visibility scoping rules for macro_rules macros rust-lang/rfcs#3067
Closed

remi-dupre added a commit to Qwant/fafnir that referenced this pull request Sep 1, 2022
add explicit dyn when using trait objects
b9a1212
Using bare trait objects is deprecated and now triggers a warning by default: rust-lang/rust#61203.

remi-dupre added a commit to Qwant/fafnir that referenced this pull request Sep 2, 2022
add explicit dyn when using trait objects
f8410ae
Using bare trait objects is deprecated and now triggers a warning by default: rust-lang/rust#61203.

enggosokbaju added a commit to enggosokbaju/Quick4Explore that referenced this pull request Jul 27, 2026
Missing dyn for trait object (bare trait object) is a warning by de…
45a2a5f
…fault now as rust-lang/rust#61203 is merged, which breaks labrpc.

mstrcokelat added a commit to mstrcokelat/devops_cool_fast_rev_02 that referenced this pull request Jul 27, 2026
Missing dyn for trait object (bare trait object) is a warning by de…
cfd6425
…fault now as rust-lang/rust#61203 is merged, which breaks labrpc.

Uh oh!

Uh oh!

Conversation

memoryruins commented May 26, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

memoryruins commented May 26, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

memoryruins commented May 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented May 28, 2019

Uh oh!

joshtriplett commented May 28, 2019 via email

Uh oh!

memoryruins commented May 28, 2019

Uh oh!

Centril commented May 28, 2019

Uh oh!

bors commented May 28, 2019

Uh oh!

Centril commented May 28, 2019

Uh oh!

bors commented May 29, 2019

Uh oh!

bors commented May 29, 2019

Uh oh!

alexcrichton commented May 31, 2019

Uh oh!

Centril commented May 31, 2019

Uh oh!

alexcrichton commented May 31, 2019

Uh oh!

Centril commented May 31, 2019

Uh oh!

alexcrichton commented Jun 3, 2019

Uh oh!

SimonSapin commented Jun 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

memoryruins commented May 26, 2019•
edited
Loading