Skip to content

[stable] Fix an ICE that hid the related error message - #61208

Closed
oli-obk wants to merge 1 commit into
rust-lang:stablefrom
oli-obk:stable_ice
Closed

[stable] Fix an ICE that hid the related error message#61208
oli-obk wants to merge 1 commit into
rust-lang:stablefrom
oli-obk:stable_ice

Conversation

@oli-obk

@oli-obkoli-obk commented May 26, 2019

Copy link
Copy Markdown
Contributor

Opening as a separate PR because the master/beta fix won't apply cleanly

r? @pietroalbini

fixes#60989

@rust-highfive

rust-highfive commented May 26, 2019

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2019
@oli-obkoli-obk mentioned this pull request May 26, 2019
Merged
@Centril

Centril commented May 26, 2019

Copy link
Copy Markdown
Contributor

We already shipped 1.35.0 so why target stable?

@emilyalbini

emilyalbini commented May 26, 2019

Copy link
Copy Markdown
Member

This is for the stable-nominated I think. Blocked until a decision is made for an eventual point release.

@rustbot modify labels: S-blocked -S-waiting-on-review

@rustbotrustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2019
@CentrilCentril added T-release Relevant to the release subteam, which will review and decide on the PR/issue. S-waiting-on-team stable-nominated Nominated for backporting to the compiler in the stable channel. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 26, 2019
@Centril

Centril commented May 26, 2019

Copy link
Copy Markdown
Contributor

Switching labels a bit to bring up on t-release's agenda. I think if we go ahead with a point release we'd also want to pack in other things.

@emilyalbiniemilyalbini added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed T-release Relevant to the release subteam, which will review and decide on the PR/issue. S-waiting-on-team T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. stable-nominated Nominated for backporting to the compiler in the stable channel. labels May 26, 2019
@emilyalbini

emilyalbini commented May 26, 2019

Copy link
Copy Markdown
Member

The stable nomination is already in the original PR: #61189

@estebank

estebank commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

This hasn't landed in beta either, right @oli-obk?

@emilyalbini

emilyalbini commented Jun 20, 2019

Copy link
Copy Markdown
Member

@estebank this is already on beta -- #61602.

@emilyalbini

emilyalbini commented Jun 23, 2019

Copy link
Copy Markdown
Member

Closing this, realistically we won't make a point release this close to 1.36.

@oli-obk
oli-obk deleted the stable_ice branch March 16, 2021 12:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emilyalbiniemilyalbini

Labels

S-blockedStatus: Blocked on something else such as an RFC or other implementation work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk@rust-highfive@Centril@emilyalbini@estebank@rustbot