Skip to content

Recover gracefully from argument with missing type or param name - #61331

Merged
bors merged 4 commits into
rust-lang:masterfrom
estebank:fn-arg-parse-recovery
Jun 3, 2019
Merged

Recover gracefully from argument with missing type or param name#61331
bors merged 4 commits into
rust-lang:masterfrom
estebank:fn-arg-parse-recovery

Conversation

@estebank

@estebankestebank commented May 29, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented May 29, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2019
@estebank

estebank commented May 29, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @varkor

@rust-highfiverust-highfive assigned varkor and unassigned eddybMay 29, 2019
Centril
Centril reviewed May 30, 2019
View reviewed changes
Comment threadsrc/libsyntax/parse/parser.rs Outdated
Comment threadsrc/libsyntax/parse/parser.rs Outdated
petrochenkov
petrochenkov reviewed May 30, 2019
View reviewed changes
Comment threadsrc/libsyntax/parse/parser.rs Outdated
@estebank
estebankforce-pushed the fn-arg-parse-recovery branch from eea7d7c to ad0d3b5CompareMay 31, 2019 01:20
varkor
varkor reviewed Jun 1, 2019
View reviewed changes
Comment threadsrc/libsyntax/parse/diagnostics.rs
@varkor

varkor commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 3, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit e275f2c has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2019
@bors

bors commented Jun 3, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e275f2c with merge c57ed9d...

bors added a commit that referenced this pull request Jun 3, 2019
@bors
Auto merge of#61331- estebank:fn-arg-parse-recovery, r=varkor
c57ed9d
Recover gracefully from argument with missing type or param name
@bors

bors commented Jun 3, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: varkor
Pushing c57ed9d to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 3, 2019
@bors
bors merged commit e275f2c into rust-lang:masterJun 3, 2019
@borsbors mentioned this pull request Jun 3, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments
+2 more reviewers
@CentrilCentrilCentril left review comments
@varkorvarkorvarkor left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@varkorvarkor

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@estebank@rust-highfive@varkor@bors@Centril@petrochenkov@eddyb