Skip to content

Stabilize exact_size_is_empty feature - #61366

Closed
tesuji wants to merge 1 commit into
rust-lang:masterfrom
tesuji:stabilize-exact_size_is_empty
Closed

Stabilize exact_size_is_empty feature#61366
tesuji wants to merge 1 commit into
rust-lang:masterfrom
tesuji:stabilize-exact_size_is_empty

Conversation

@tesuji

@tesujitesuji commented May 30, 2019

Copy link
Copy Markdown
Contributor

FCP done in #35428 (comment)

Closes#35428

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbotrustbot added the T-libs-api [DEPRECATED; DO NOT USE] label May 30, 2019
@jonas-schievinkjonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label May 30, 2019
@jonas-schievinkjonas-schievink added this to the 1.37 milestone May 30, 2019
@Centril

Centril commented May 30, 2019

Copy link
Copy Markdown
Contributor

r? @SimonSapin

cc @rust-lang/libs
cc @scottmcm -- you had concerns?

@scottmcm

scottmcm commented May 31, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Note that the PR referenced in the OP here is over two years old, and is_empty was explicitly removed from stabilization due to concerns raised (#35428 (comment)), so I don't think this PR is a fait accompli.

I continue to feel that .is_empty() is too useful to be limited to just ExactSizeIterators.

@SimonSapin

SimonSapin commented May 31, 2019

Copy link
Copy Markdown
Contributor

At a risk of rehashing the previous thread, please expand on what you would prefer instead. If it should not be limited to that, then what should it be? That plus methods on other existing trait(s) and/or inherent methods on some types? A dedicated trait? Why? Would a dedicated trait be used in a bound in a generic context?

Having someone champion and argue for a counter-proposal could be a way to unblock this.

@Dylan-DPC-zzDylan-DPC-zz added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2019
@CentrilCentril modified the milestones: 1.37, 1.38Jul 2, 2019
@scottmcmscottmcm mentioned this pull request Jul 8, 2019
Open
@tesuji
tesujiforce-pushed the stabilize-exact_size_is_empty branch from 54699aa to 2974a70CompareJuly 9, 2019 08:16
@CentrilCentril modified the milestones: 1.38, 1.39Aug 13, 2019
@CentrilCentril modified the milestones: 1.39, 1.40Sep 26, 2019
@tesuji
tesujiforce-pushed the stabilize-exact_size_is_empty branch 2 times, most recently from 6dae8d4 to f478159CompareSeptember 28, 2019 16:57
@bors

bors commented Oct 19, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #65588) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji
tesujiforce-pushed the stabilize-exact_size_is_empty branch from f478159 to f938d3bCompareOctober 19, 2019 09:24
@Mark-Simulacrum

Mark-Simulacrum commented Oct 24, 2019

Copy link
Copy Markdown
Member

I'm going to close this PR as it seems like discussion can happen on the issue until we reach a conclusion (#35428). Thanks for the PR, though!

@Mark-SimulacrumMark-Simulacrum added S-blocked-closed and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 24, 2019
@CentrilCentril removed this from the 1.40 milestone Nov 7, 2019
@jyn514jyn514 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-blocked-closed labels Mar 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SimonSapinSimonSapin

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-blockedStatus: Blocked on something else such as an RFC or other implementation work.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add is_empty function to ExactSizeIterator

11 participants

@tesuji@Centril@scottmcm@SimonSapin@bors@Mark-Simulacrum@jonas-schievink@rust-highfive@Dylan-DPC-zz@jyn514@rustbot